Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more fuzz tests for point/vector/direction functions #103

Open
ianmackenzie opened this issue Jul 23, 2019 · 2 comments
Open

Add more fuzz tests for point/vector/direction functions #103

ianmackenzie opened this issue Jul 23, 2019 · 2 comments
Labels
good first issue help wanted

Comments

@ianmackenzie
Copy link
Owner

ianmackenzie commented Jul 23, 2019 •
edited
Loading

The Point#d, Vector#d and Direction#d modules were recently optimized in the coordinate-systems branch to avoid unnecessary object allocations and function calls, but this also meant most functions got more verbose and therefore more prone to typos. It would be very useful to add some more fuzz and/or hardcoded tests for the various functions in these modules, following the patterns in the existing Tests.Point3d etc. test modules. Please make sure you make any PRs against the coordinate-systems branch!
@ianmackenzie
Copy link
Owner Author

Just found one such typo bug myself and added a couple of tests for it: 5065e5d

@ianmackenzie
Copy link
Owner Author

Update: the coordinate-systems branch has been merged back into master and no longer exists, so please make any PRs against master instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ianmackenzie