Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

Bug recompile on controllers files does not working #52

Open
isAlmogK opened this issue May 27, 2018 · 7 comments
Open

Bug recompile on controllers files does not working #52

isAlmogK opened this issue May 27, 2018 · 7 comments
Labels

Comments

@isAlmogK
Copy link

When I edit a controller and then refresh my view I'm not getting the updated code, it's not updating attached gif showing the issue, due to the plugin once disabled works as expected

bug

@iampeterbanjo
Copy link
Owner

@AlmogRnD thanks for reporting this issue with the gif. do you have a repo that I could use to test this?

@isAlmogK
Copy link
Author

isAlmogK commented Jun 4, 2018

I don't have a repo

@iampeterbanjo
Copy link
Owner

what triggers the elixir app to recompile and show the changes? is it a node script or something else?

@TimonVS
Copy link

TimonVS commented Jun 27, 2018

I'm running into the same problem. When I have this plugin enabled, none of my code recompiles anymore. This can be reproduced by setting up a new Phoenix project (mix phx.new hello), whenever you change any code in a controller and make a new request (refreshing the page for instance) it should recompile the code, but it doesn't. When I disable the extension it works fine again. It took me quite a while to figure out what was causing it though 😅.

@iampeterbanjo
Copy link
Owner

I'm really lost with this issue. @TimonVS Is there a repo that I can test this out with?

@myknbani
Copy link

@iampeterbanjo happens to me too. Is it because Credo compiles the code already, and the Phoenix code reloader doesn't pick it up?

https://stackoverflow.com/a/51058655/2310634

I might try a minimal repo later.

@iampeterbanjo
Copy link
Owner

hi @myknbani, I think it might be related to this issue #25

From what I understand, there is some sort of collision happening when Elixir is being compiled. Setting an environment variable to set a different build path when Credo is run, in the context of this extension, could be the fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants