Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearly separate Controls, Camera and CameraUtils #945

Open
jailln opened this issue Dec 3, 2018 · 1 comment
Open

Clearly separate Controls, Camera and CameraUtils #945

jailln opened this issue Dec 3, 2018 · 1 comment

Comments

@jailln
Copy link
Contributor

jailln commented Dec 3, 2018

Controls, Camera and CameraUtils are not clearly separated and share some responsabilities. Some GlobeControls methods (such as getCameraCoordinate(), getCameraOrientation(), getCameraTargetGeoPosition(), getCameraTargetPosition(), etc.) are for instance related to the camera.

We should clearly separate these classes with the following responsabilities:

  • Camera: simulation of the physical camera
  • CameraUtils: utils to move the camera
  • Controls: handle user events and uses Camera and CameraUtils to move the Camera when needed
@jailln jailln changed the title Move some GlobeControls controls methods to Camera Move some GlobeControls methods to Camera Dec 3, 2018
@jailln jailln added the design label Dec 3, 2018
@jailln jailln changed the title Move some GlobeControls methods to Camera Move some GlobeControls methods to Camera or CameraUtils Dec 3, 2018
@gchoqueux
Copy link
Contributor

Yes indeed, this needs to be clarified. We think to move these methods in the viewer or camera. But before we want only one Viewer (instead of PlanarViewer, GlobeViewer, PanoramaViewer and Viewer) and refactor the Controls.

@jailln jailln changed the title Move some GlobeControls methods to Camera or CameraUtils Clearly separate Controls, Camera and CameraUtils Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants