You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Feel free to simplify things, but please keep something that is extensible by design ! (support custom layers with custom properties, custom sharders...)
config.options has been almost removed since the creation of the sources, so it doesn't have much senses to keep it.
Ok for deprecating this.options.
This assignment exists to not forget layer properties. It would assume and document all properties and not used Object.Assign.
I'm for removing this too, we need to complete the documentation first though.
Feel free to simplify things, but please keep something that is extensible by design ! (support custom layers with custom properties, custom shaders...)
Yes for extensible design: all properties of a layer, source etc... are accessible after instantiation. Is there a case where this would cause problems ? (for example in the init of a certain type of layer ?)
In Layer class two properties aren't, may be, usefulness.
in constructor:
this.options
config.options
has been almost removed since the creation of the sources, so it doesn't have much senses to keep it.Object.assign(this, config)
This assignment exists to not forget layer properties. It would assume and document all properties and not used
Object.Assign
.The text was updated successfully, but these errors were encountered: