We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
itowns/src/Controls/GlobeControls.js
Line 189 in c862ca7
The animationplayer is unique for every instance of globecontrols but the callback can be mixed up between multiple views.
for example, I have 2 different views here, and when I trigger an animation on VIEW-1, the VIEW-2 is also affected:
It seems to be this part of the code that is causing this issue:
Lines 550 to 552 in c862ca7
But as we can notice, player.stop() is also called in a lot of places... Maybe some code cleanup can be done concerning this player.
player.stop()
The text was updated successfully, but these errors were encountered:
mgermerie
No branches or pull requests
Context
itowns/src/Controls/GlobeControls.js
Line 189 in c862ca7
The animationplayer is unique for every instance of globecontrols but the callback can be mixed up between multiple views.
for example, I have 2 different views here, and when I trigger an animation on VIEW-1, the VIEW-2 is also affected:
Screencast.from.07-10-2024.15.59.52.webm
Possible Cause/Fix/Solution
It seems to be this part of the code that is causing this issue:
itowns/src/Controls/GlobeControls.js
Lines 550 to 552 in c862ca7
But as we can notice,
player.stop()
is also called in a lot of places... Maybe some code cleanup can be done concerning this player.The text was updated successfully, but these errors were encountered: