Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VectorTileLayer): fix icon.id with {xx} or/and .stops #2330

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

ftoromanoff
Copy link
Contributor

Fix Issue #2328

There is an issue with icons and sprites linked with a bad interpretation of properties containing {data} and/or stops properties.

This PR aims at solving the issue

@ftoromanoff ftoromanoff marked this pull request as ready for review May 31, 2024 13:45
@ftoromanoff ftoromanoff force-pushed the fixVectorTileSprite branch 2 times, most recently from e159c7a to 990558d Compare May 31, 2024 16:40
@ftoromanoff ftoromanoff linked an issue Jun 3, 2024 that may be closed by this pull request
@ftoromanoff ftoromanoff force-pushed the fixVectorTileSprite branch from 990558d to 4b8efff Compare June 3, 2024 09:09
@ftoromanoff ftoromanoff force-pushed the fixVectorTileSprite branch 6 times, most recently from ffcd766 to 9f3d6fd Compare June 14, 2024 15:38
@ftoromanoff ftoromanoff force-pushed the fixVectorTileSprite branch from 9f3d6fd to 786e97f Compare June 18, 2024 13:39
@Desplandis Desplandis requested a review from AnthonyGlt June 24, 2024 18:47
@ftoromanoff
Copy link
Contributor Author

@AnthonyGlt could you have a look at this PR?

Copy link
Contributor

@AnthonyGlt AnthonyGlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the MR and for the unit test !

@ftoromanoff ftoromanoff merged commit 982b908 into iTowns:master Jul 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem adding vector tiles map
2 participants