Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor Feature #1295

Open
gchoqueux opened this issue Jan 14, 2020 · 1 comment
Open

refactor Feature #1295

gchoqueux opened this issue Jan 14, 2020 · 1 comment
Labels
refactor 🏭 to-specify
Milestone
2.xx.x

Comments

@gchoqueux
Copy link
Contributor

add properties like: vertices, normal, crs and remove feature from function params.

I'm not convinced by this, because in some case that would be a lot of parameters. See this function: we need the crs, vertices and then normals and size in the _extendBuffer call. WDYT ?

Originally posted by @zarov in #1290 (comment)
@gchoqueux gchoqueux added this to the 2.xx.x milestone Jan 14, 2020
@gchoqueux
Copy link
Contributor Author

Feature needs a refactoring, we have the necessary hindsight. There is a need to simplify/clarify the code and encapsulate this part of the code.

@gchoqueux gchoqueux mentioned this issue Jan 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor 🏭 to-specify
Projects
None yet
Milestone
2.xx.x
Development

No branches or pull requests
2 participants
@gchoqueux @jailln