Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Casa MS file path args should support Visibility class #616

Closed
Lukas113 opened this issue Sep 12, 2024 · 1 comment · Fixed by #620
Closed

Casa MS file path args should support Visibility class #616

Lukas113 opened this issue Sep 12, 2024 · 1 comment · Fixed by #620
Assignees
@mpluess
Labels
enhancement New feature or request

Comments

@Lukas113
Copy link
Collaborator

This issue originates from PR #612 where we had a discussion about whether ImageCleaner.create_cleaned_image should be a Visibility object or not. Lookup on discussion details can be looked up in the PR.

The TLDR is make visibility args positonal-only and accept casa MS and Visibility. This is an API breaking change.
@Lukas113 Lukas113 added the enhancement New feature or request label Sep 12, 2024
@Lukas113 Lukas113 mentioned this issue Sep 12, 2024
Merged
@mpluess mpluess mentioned this issue Sep 13, 2024
Closed
6 tasks
@mpluess mpluess self-assigned this Sep 13, 2024
@mpluess
Copy link
Member

mpluess commented Sep 13, 2024

Assigned myself since I wanted to address this anyway in #595

@mpluess mpluess mentioned this issue Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpluess mpluess

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve handling of different visibility formats i4Ds/Karabo-Pipeline
2 participants
@mpluess @Lukas113