-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrollbars autohide even with System Preferences
→ General
→ Show Scroll Bars
set to "Always"
#19
Comments
I guess that's because of That said, in my Waterfox-G3 browser the same option exists but keeping it to "false" doesn't force the scrollbars to hide. Does stock FF on 10.15+ do the right thing or is this indeed FF not respecting an OS setting? |
Stock FF 78 definitely respected OS settings, so I assumed it still does. Unfortunately I don't have easy access to vanilla modern Firefox. If this is in fact an upstream issue I'll close the ticket. |
On Thursday November 07 2024 18:17:17 Jonathan wrote:
Stock FF 78 definitely respected OS settings, so I assumed it still does.
I can confirm, and I can't test it either. I guess it depends on how important the theming and behaviour of scrollbars is for upstream. Apple themselves seem to have been maintaining the UI option, judging from the SDK documentation cited below.
Isn't there a community support forum where one could ask?
Or scan the source for the use of [NSScroller preferredScrollerStyle] and [NSScroller scrollerStyle] (see https://developer.apple.com/documentation/appkit/nsscroller/1523620-preferredscrollerstyle?language=objc). But from what I understand an application that uses this system API doesn't have the option to set scrollbars to hide automatically, only to set them to a legacy (pre-10.7) style instead of overlay style. And that's not even what seems to be happening when you toggle the FF config option - if my assumption is correct that those legacy scrollers would be outside the view.
|
The "overlay" style means autohiding, aka what FF Dynasty does at the moment. But I assume Firefox doesn't literally use the system scrollbar, it draws its own to mimic the system one. |
On Friday November 08 2024 05:02:15 Jonathan wrote:
The "overlay" style means autohiding
No, from what I understand it means "able to autohide, following the user's choices in the Sys Prefs". There is only the choice between overlay (there's even an "overlay compatible" property) and "legacy".
, aka what FF Dynasty does at the moment. But I assume Firefox doesn't literally use the system scrollbar, it draws its own to mimic the system one.
I think so too but if that is what it does then it is very likely that the official build does the same thing. The documentation I have seen so far doesn't say anything about how one could figure out the user's choice, it just says that respecting that choice is done automatically (and in most cases, on the fly whenever the setting is changed).
Isn't or wasn't there a setting somewhere to allow theming of the scrollbars, or is that in Chromium? *That* could correspond to using the system scrollers vs. using a custom implementation.
|
On Friday November 08 2024 05:02:15 Jonathan wrote:
But I assume Firefox doesn't literally use the system scrollbar
Apparently it does, and this is the 1st revision where it sets the preferred scroll style to "overlay":
https://searchfox.org/mozilla-central/rev/52e6225f5f2d6709bfaaeea5abf957ed2d29f8bb/widget/cocoa/nsLookAndFeel.mm#445
(see https://bugzilla.mozilla.org/show_bug.cgi?id=1702602)
I don't know how to match that commit to a revision but it's 4 years ago which could well correspond to v78. What's surprising is that the "preferred" property is readonly (https://developer.apple.com/documentation/appkit/nsscroller/1523620-preferredscrollerstyle?language=objc)
The change before was in 2013 and introduced 10.7-style (overlay) scrollers: https://bugzilla.mozilla.org/show_bug.cgi?id=636564
|
Wow!!! Thank you for checking this. I'm sorry, I should have done that myself, it just never occurred to me Firefox would be this stupid. |
Wait I misunderstood, you were just saying it uses the system scrollbar, not that this problem necessarily exists in upstream Firefox. I'm still going to leave this issue closed until I'm sure this isn't an upstream problem. |
On Friday November 08 2024 10:01:45 Jonathan wrote:
Wait I misunderstood, you were just saying it uses the system scrollbar, not that this problem necessarily exists in upstream Firefox.
No, I *was* also saying that it does something more than using the system scrollbar. Or tries to, as the property is read-only, and *probably* by default set to "overlay" already.
This is the only other hit on "ScrollerStyle":
https://searchfox.org/mozilla-central/source/widget/cocoa/nsLookAndFeel.mm#631
That bit of code was first introduced (to nsChildView.mm) as a result of https://bugzilla.mozilla.org/show_bug.cgi?id=868498 .
That bug title suggests that there *may* have been a change in the change handler (scrollbarsChanged); I'll let you see if that's the case.
|
I was able to confirm this is not an issue in upstream Firefox. |
@RJVB Wow! That's so weird! For me they hide a few seconds after I stop scrolling, as if on mobile (or, as is expected on macOS 10.7+ when I've tested in a clean VM, many times! |
I've tested in a clean VM, many times!
Maybe that's the reason? I suppose there's not a single form of hardware acceleration in the VM host you're using?
|
Well, it doesn't work outside the VM either. |
@RJVB I hate to ask but I am immensely curious if the scrollbars still show up for you in a fresh profile. Like if you run in Terminal:
Do the scrollbars show up? |
On Thursday January 02 2025 16:30:03 Jonathan wrote:
@RJVB I hate to ask
Yeah, really now! :)
Do the scrollbars show up?
Will try. You may have noticed that my titlebar is more compact (I *think* via a flag that says compact which has 3 settings that aren't monotonically making the UI more or less compact...) *and* that I don't have favicons in my tabs (really don't remember how I managed that). Either could have a side-effect on the scrollbar thing I suppose.
EDIT: but they do show up.
|
Huh! What is going on? Can anyone else on Mavericks chime in? Do the scrollbars appear permanently when you change the setting in System Preferences? |
you're the greediest person i know @Wowfunhappy. you really earned the "wow" in your name. peep the latest 134 and it should be fixed. |
yo @bag-xml i know you gonna bob ya head to this one i have a fringe theory that CANADIAN scott storch was the ghost pianist. it reeks of him. post-2001 after still dre. it has to be him. no one else could do it at that time. don't let the bubbling sounds at the beginning give you any ideas lol! |
lol 😭 |
On Thursday January 02 2025 19:57:49 gagan sidhu wrote:
you really earned the "wow" in your name.
(let's hope the 2nd component is "fun" and not just "f" ? ^^)
|
Yes it's fixed! Thank you! (I guess we don't know why RJVB's Firefox had magic powers?)
Fun fact, I came up with this username on a whim when I was 11 years old. Now it's my online identity and I can't change it. A warning to any child reading this, pick your username carefully!!! |
On Friday January 03 2025 04:59:06 Jonathan wrote:
(I guess we don't know why RJVB's Firefox had magic powers?)
Maybe we'll know more when I get back to my Mac, upgrade and realise my copy was Dorian Gray's picture (i.e. scrollbars start misbehaving) ;)
|
In OS X's "General" Preference Pane, there is a setting called "Show scroll bars" with three options (not in the below order):
#1
if a trackpad is connected, otherwise like#2
.In Firefox Dynasty, scrollbars always hide automatically regardless of which option is selected or what input device is in use.
The text was updated successfully, but these errors were encountered: