Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render modifications not applied to damage in new render scheduler #8978

Closed
2 of 6 tasks
raybbian opened this issue Jan 7, 2025 · 1 comment
Closed
2 of 6 tasks
Labels
bug Something isn't working

Comments

@raybbian
Copy link
Contributor

raybbian commented Jan 7, 2025

Already reported ? *

  • I have searched the existing open and closed issues.

Regression?

Not a regression - it's bug regarding new feature

System Info and Hyprland Version

.

Description

After #8928, render pass elements are now correctly rendered at their corresponding positions after render modifications are applied. However, render modifications are not applied to damage calculations in CRenderPass::simplify(). This causes improper damage when rendering elements with modifications applied.

A workaround is to disable simplification for that render pass completely, but I'd imagine this negates any performance improvement brought in by the new system.

How to reproduce

  1. Add several elements to the render pass in a way that render modifications are applied to them.
  2. Damage calculations are incorrect, resulting in visual artifacts.

Attach not paste

  • I understand that all text files must be attached, and not pasted directly. If not respected, this issue will likely get closed as spam

Checklist of files to include below

  • Hyprland config - hyprctl systeminfo -c (always include)
  • Crash report (always include in case of crash)
  • Video (always include in case of a visual bug)
  • Logs (might contain useful info such as errors)

Additional info & File uploads

No response

@raybbian raybbian added the bug Something isn't working label Jan 7, 2025
@vaxerski
Copy link
Member

vaxerski commented Jan 8, 2025

IIRC render modifications can rotate. In that case, we can't do much here other than disable simplification, as we cant rotate regions.

If your plugin only uses modifications from time to time, it's probably fine.

@raybbian raybbian closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants