Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure mentions do not capture punctuation symbols after username #6801

Closed
acelaya opened this issue Feb 7, 2025 · 0 comments · Fixed by #6798
Closed

Make sure mentions do not capture punctuation symbols after username #6801

acelaya opened this issue Feb 7, 2025 · 0 comments · Fixed by #6798
Assignees

Comments

@acelaya
Copy link
Contributor

acelaya commented Feb 7, 2025

Some of the logic in helper functions, when detecting if the caret is overlapping an @mention, or when searching for @mention patterns in a piece of text, are including punctuation characters in the mention. We need to avoid that.

An example, for a text like Hello @user, how are you?, the mention that we detect is @user, instead of @user.

Rob suggested applying a regexp like the one used by the backend: #6797 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant