-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update PR template #896
Conversation
Signed-off-by: mkbreuningIOHK <[email protected]>
cb814b4
to
1a01d59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Requested minor changes
Co-authored-by: Pete Vielhaber <[email protected]> Signed-off-by: mkbreuning <[email protected]>
Co-authored-by: Pete Vielhaber <[email protected]> Signed-off-by: mkbreuning <[email protected]>
Explicit what is the ADR acronym Signed-off-by: mkbreuning <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comment with the allowlist link
Signed-off-by: essbante-io <[email protected]>
@petevielhaber @essbante-io , thanks to review the update and approve so this PR can be merged. |
|
Signed-off-by: mkbreuningIOHK <[email protected]> Signed-off-by: mkbreuning <[email protected]> Signed-off-by: essbante-io <[email protected]> Co-authored-by: Pete Vielhaber <[email protected]> Co-authored-by: essbante-io <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>
Signed-off-by: mkbreuningIOHK <[email protected]> Signed-off-by: mkbreuning <[email protected]> Signed-off-by: essbante-io <[email protected]> Co-authored-by: Pete Vielhaber <[email protected]> Co-authored-by: essbante-io <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>
Signed-off-by: mkbreuningIOHK <[email protected]> Signed-off-by: mkbreuning <[email protected]> Signed-off-by: essbante-io <[email protected]> Co-authored-by: Pete Vielhaber <[email protected]> Co-authored-by: essbante-io <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>
Signed-off-by: mkbreuningIOHK <[email protected]> Signed-off-by: mkbreuning <[email protected]> Signed-off-by: essbante-io <[email protected]> Co-authored-by: Pete Vielhaber <[email protected]> Co-authored-by: essbante-io <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>
Signed-off-by: mkbreuningIOHK <[email protected]> Signed-off-by: mkbreuning <[email protected]> Signed-off-by: essbante-io <[email protected]> Co-authored-by: Pete Vielhaber <[email protected]> Co-authored-by: essbante-io <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>
Description:
The change is to use a new PR template.
Context:
See the related issue. We will try this PR template and work by iteration to improve it. The goal is that it is simple and added-value for the community.
Checklist: