Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update PR template #896

Merged
merged 6 commits into from
Feb 23, 2024
Merged

docs: update PR template #896

merged 6 commits into from
Feb 23, 2024

Conversation

mkbreuningIOHK
Copy link
Contributor

@mkbreuningIOHK mkbreuningIOHK commented Feb 16, 2024

Description:

The change is to use a new PR template.

Context:

See the related issue. We will try this PR template and work by iteration to improve it. The goal is that it is simple and added-value for the community.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with HL-Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@mkbreuningIOHK mkbreuningIOHK linked an issue Feb 16, 2024 that may be closed by this pull request
6 tasks
@atala-dev atala-dev added the ci label Feb 16, 2024
Signed-off-by: mkbreuningIOHK <[email protected]>
Copy link
Contributor

github-actions bot commented Feb 16, 2024

Integration Test Results

12 files  ±0  12 suites  ±0   2s ⏱️ ±0s
25 tests ±0  25 ✅ ±0  0 💤 ±0  0 ❌ ±0 
26 runs  ±0  26 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 35594b3. ± Comparison against base commit d86436c.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 16, 2024

Unit Test Results

 86 files  ±0   86 suites  ±0   20m 2s ⏱️ -36s
734 tests ±0  726 ✅ ±0  8 💤 ±0  0 ❌ ±0 
739 runs  ±0  731 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 35594b3. ± Comparison against base commit d86436c.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@petevielhaber petevielhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Requested minor changes

mkbreuningIOHK and others added 3 commits February 19, 2024 15:25
Co-authored-by: Pete Vielhaber <[email protected]>
Signed-off-by: mkbreuning <[email protected]>
Co-authored-by: Pete Vielhaber <[email protected]>
Signed-off-by: mkbreuning <[email protected]>
Explicit what is the ADR acronym

Signed-off-by: mkbreuning <[email protected]>
Copy link
Contributor

@essbante-io essbante-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment with the allowlist link

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@mkbreuningIOHK
Copy link
Contributor Author

@petevielhaber @essbante-io , thanks to review the update and approve so this PR can be merged.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mkbreuningIOHK mkbreuningIOHK merged commit 1c6d894 into main Feb 23, 2024
11 checks passed
@mkbreuningIOHK mkbreuningIOHK deleted the 895-update-the-pr-template branch February 23, 2024 15:18
shotexa pushed a commit that referenced this pull request Mar 6, 2024
Signed-off-by: mkbreuningIOHK <[email protected]>
Signed-off-by: mkbreuning <[email protected]>
Signed-off-by: essbante-io <[email protected]>
Co-authored-by: Pete Vielhaber <[email protected]>
Co-authored-by: essbante-io <[email protected]>
Signed-off-by: Shota Jolbordi <[email protected]>
shotexa pushed a commit that referenced this pull request Mar 6, 2024
Signed-off-by: mkbreuningIOHK <[email protected]>
Signed-off-by: mkbreuning <[email protected]>
Signed-off-by: essbante-io <[email protected]>
Co-authored-by: Pete Vielhaber <[email protected]>
Co-authored-by: essbante-io <[email protected]>
Signed-off-by: Shota Jolbordi <[email protected]>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: mkbreuningIOHK <[email protected]>
Signed-off-by: mkbreuning <[email protected]>
Signed-off-by: essbante-io <[email protected]>
Co-authored-by: Pete Vielhaber <[email protected]>
Co-authored-by: essbante-io <[email protected]>
Signed-off-by: Shota Jolbordi <[email protected]>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: mkbreuningIOHK <[email protected]>
Signed-off-by: mkbreuning <[email protected]>
Signed-off-by: essbante-io <[email protected]>
Co-authored-by: Pete Vielhaber <[email protected]>
Co-authored-by: essbante-io <[email protected]>
Signed-off-by: Shota Jolbordi <[email protected]>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: mkbreuningIOHK <[email protected]>
Signed-off-by: mkbreuning <[email protected]>
Signed-off-by: essbante-io <[email protected]>
Co-authored-by: Pete Vielhaber <[email protected]>
Co-authored-by: essbante-io <[email protected]>
Signed-off-by: Shota Jolbordi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the PR template
6 participants