Error and docker containers not stopped when stopping the OpenAPI Demo

[swcurran]

What I'm trying to do

Start and stop the OpenAPI demo such that my docker environment is the same before and after e.g., nothing from the demo is running after I stop it.

1. Clone the repo.
2. Install the prerequisites
3. Start the demo with make run-openapi-demo
4. Stop the demo with make stop-openapi-demo

Note -- how to stop the demo is not included in the documentation. I could add that in PR, but the errors (below) I'm not sure what to do with.

Expected result

The OpenAPI demo stops cleanly and all of the running containers for the demo are stopped.

Actual result

An error from the make command:

Removing network agent-rest_bdd_net
ERROR: error while removing network: network agent-rest_bdd_net id 57b1ddaacff4854f266d5f5d3afbe775378f7d4ee362014efbd4ec0a195cfbba has active endpoints
Makefile:117: recipe for target 'stop-openapi-demo' failed
make: *** [stop-openapi-demo] Error 1

A set of OpenAPIDemo containers are still running:

CONTAINER ID   IMAGE                                   COMMAND                  CREATED              STATUS                  PORTS
                                                                            NAMES
ce51439c12dc   swaggerapi/swagger-ui                   "/docker-entrypoint.…"   About a minute ago   Up About a minute       80/tcp, 0.0.0.0:9089->8080/tcp, :::9089->8080/tcp
                                                                            bob.openapi.demo.com
f9c26a707456   swaggerapi/swagger-ui                   "/docker-entrypoint.…"   About a minute ago   Up About a minute       80/tcp, 0.0.0.0:8089->8080/tcp, :::8089->8080/tcp
                                                                            alice.openapi.demo.com
ec9d571f4c0a   swaggerapi/swagger-ui                   "/docker-entrypoint.…"   About a minute ago   Up About a minute       80/tcp, 0.0.0.0:10089->8080/tcp, :::10089->8080/tcp
                                                                            carl.openapi.demo.com
0e89e20a8892   swaggerapi/swagger-ui                   "/docker-entrypoint.…"   About a minute ago   Up About a minute       80/tcp, 0.0.0.0:10099->8080/tcp, :::10099->8080/tcp
                                                                            carl.router.openapi.demo.com
86c9b6af66e0   swaggerapi/swagger-ui                   "/docker-entrypoint.…"   About a minute ago   Up About a minute       80/tcp, 0.0.0.0:10079->8080/tcp, :::10079->8080/tcp
                                                                            dave.router.openapi.demo.com
9c4c9a6289d3   swaggerapi/swagger-ui                   "/docker-entrypoint.…"   About a minute ago   Up About a minute       80/tcp, 0.0.0.0:10069->8080/tcp, :::10069->8080/tcp
                                                                            dave.openapi.demo.com

To stop the extra containers, run:

docker stop aries.bdd.sidetree.mock dave.router.openapi.demo.com dave.openapi.demo.com carl.router.openapi.demo.com carl.openapi.demo.com bob.openapi.demo.com alice.openapi.demo.com