Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowlist claim response cache refresh #254

Merged
merged 6 commits into from
Feb 12, 2025
Merged

Allowlist claim response cache refresh #254

merged 6 commits into from
Feb 12, 2025

Conversation

bitbeckers
Copy link
Collaborator

@bitbeckers bitbeckers commented Feb 10, 2025 •
edited
Loading

Updates the specified table to monitor for cache invalidations. The cache invalidation works, but the query needs to call both count and data. As discussed in #255

Works on #251

Jipperism and others added 5 commits January 30, 2025 14:31
@Jipperism
Merge pull request #232 from hypercerts-org/develop
fd7e468 
Push to PRD
@Jipperism
Merge pull request #234 from hypercerts-org/develop
c90b545 
fix: improve error handling in hypercert orders resolver
@bitbeckers
Merge pull request #239 from hypercerts-org/develop
028f072 
Push to PRD
@bitbeckers
chore(update): dependency updates
751babf 
Updates dependencies and generated content of API
@bitbeckers
fix(cache): invalidate based on correct allow list records
107d520 
Updates the cache invalidation method to invalidate based on changes to
hypercert_allow_list_records instead of allow_lists. This enforces cache
invalidation when a record is claimed
@bitbeckers bitbeckers added the bug Something isn't working label Feb 10, 2025
@bitbeckers bitbeckers self-assigned this Feb 10, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 10, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 24.44% (🎯 24%) 1064 / 4352
🟢 Statements 24.44% (🎯 24%) 1064 / 4352
🟢 Functions 60.21% (🎯 59%) 56 / 93
🟢 Branches 72.24% (🎯 72%) 177 / 245
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/client/supabase.ts 0% 0% 0% 0% 1-450
Generated in workflow #63 for commit 6f8b777 by the Vitest Coverage Report Action

@bitbeckers bitbeckers linked an issue Feb 10, 2025 that may be closed by this pull request
Allowlist records claimed don't invalidate the cache #251
Open
@bitbeckers bitbeckers mentioned this pull request Feb 11, 2025
Open
Jipperism
Jipperism requested changes Feb 11, 2025
View reviewed changes
src/client/supabase.ts Outdated Show resolved Hide resolved
src/client/supabase.ts Show resolved Hide resolved
@bitbeckers
fix(review): unused line and invalidation parameters
6f8b777 
- removes unused payload line in supabase.ts
- when invalidation allowlist record cache on update use record id
- when invalidating allowlist record cache on insert invalidate all
@bitbeckers bitbeckers merged commit 1f3beb6 into develop Feb 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jipperism Jipperism Jipperism approved these changes

@pheuberger pheuberger Awaiting requested review from pheuberger

Assignees

@bitbeckers bitbeckers

Labels
bug Something isn't working
Projects
Hypercerts dev team daily ops
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allowlist records claimed don't invalidate the cache
2 participants
@bitbeckers @Jipperism