Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DB] Addresses lower/uppercase shouldn't matter #151

Open
bitbeckers opened this issue Sep 3, 2024 · 1 comment
Open

[DB] Addresses lower/uppercase shouldn't matter #151

bitbeckers opened this issue Sep 3, 2024 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@bitbeckers
Copy link
Collaborator

bitbeckers commented Sep 3, 2024

We need to restore the ilike functionality, i.e. case unsensitive search, to fix the current querying set up:

 const queryRes = await request(HYPERCERTS_API_URL_GRAPH, query, {
      where: { creator_address: { eq: creatorAddress.toLowerCase() } },
    });

  const queryRes = await request(HYPERCERTS_API_URL_GRAPH, query, {
      where: { fractions: { owner_address: { eq: getAddress(ownerAddress) } } },
    });

It appears that the addresses are stored using different formats, but regardless the API shouldn't care to facilatate easier querying

@bitbeckers bitbeckers converted this from a draft issue Sep 3, 2024
@bitbeckers bitbeckers self-assigned this Sep 3, 2024
@bitbeckers bitbeckers added enhancement New feature or request bug Something isn't working labels Sep 3, 2024
@bitbeckers bitbeckers removed their assignment Sep 3, 2024
@holkexyz
Copy link
Member

This is done, right @bitbeckers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: Ready
Development

No branches or pull requests

2 participants