Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

푸쉬알림 스케줄러 구현 #5

Merged
merged 3 commits into from
Mar 29, 2022
Merged

푸쉬알림 스케줄러 구현 #5

merged 3 commits into from
Mar 29, 2022

Conversation

hyejungg
Copy link
Member

@hyejungg hyejungg commented Mar 28, 2022

What is this PR? 🔍

기존 api 서버에 존재하는 푸쉬알림 스케줄러 부분을 별도의 server로 분리합니다.

Key Changes 🔑

  1. �db connection 부분을 모듈화하였습니다.
    • 반복되는 코드를 줄이기 위함 (api 서버에도 반영 예정)
    • 가변인자 비동기 함수로 빼두어 호출하도록 변경
     const connection = await pool.connection(async (conn) => conn); //반복
     const [rows] = await connection.query(sqlSelect, [userId]); //arg만 달라짐
     connection.release(); //반복

To Reviewers 📢

  • 테스트를 도와주셔서 감사함니다.. 코드 내용은 기존과 동일합니다!

@hyejungg hyejungg added the feat 새 기능 추가 label Mar 28, 2022
@hyejungg hyejungg requested a review from youngjinc March 28, 2022 15:34
@hyejungg hyejungg self-assigned this Mar 28, 2022
@hyejungg hyejungg linked an issue Mar 28, 2022 that may be closed by this pull request
@hyejungg hyejungg merged commit a81e2f2 into dev Mar 29, 2022
@hyejungg hyejungg deleted the dev-feat-scheduler branch March 31, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새 기능 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

푸쉬 알림 스케줄러 구현
1 participant