Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saves submissions marked as spam by honeypot plugin #32

Closed
chrislam opened this issue Nov 12, 2018 · 1 comment · May be fixed by #186
Closed

Saves submissions marked as spam by honeypot plugin #32

chrislam opened this issue Nov 12, 2018 · 1 comment · May be fixed by #186

Comments

@chrislam
Copy link

Not sure if this is strictly within scope of this plugin as I'm trying to use https://github.com/craftcms/contact-form-honeypot with this plugin.

When contact-form-honeypot sees it's honeypot input has a value, it sets isSpam to true and no email is sent. This is all expected.

This plugin does not check the state of the isSpam flag before saving a form submission to the database. Not sure if this is the intention or possibly there is a race condition here due to the use of event handlers?

riasvdv pushed a commit that referenced this issue Dec 3, 2018
@riasvdv
Copy link
Contributor

riasvdv commented Dec 3, 2018

I've added a potential fix in 1.0.12. There's not more that I can do if this doesn't fix it because then it's an issue of the order of the event handlers. You could open an issue with the honeypot plugin so they can specify that their event has to be handled first: https://www.yiiframework.com/doc/guide/2.0/en/concept-events#event-handler-order

@riasvdv riasvdv closed this as completed Dec 3, 2018
nstCactus added a commit to nstCactus/craft-contact-form-extensions that referenced this issue Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants