Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not force port 9000 for prometheus #3062

Open
AndreasMadsen opened this issue Feb 26, 2025 · 0 comments
Open

Do not force port 9000 for prometheus #3062

AndreasMadsen opened this issue Feb 26, 2025 · 0 comments

Comments

@AndreasMadsen
Copy link

AndreasMadsen commented Feb 26, 2025

Feature request

The Prometheus builder, use port 9000 by default. This can be changed with e.g builder.with_http_listener(([0, 0, 0, 0], 9001)), however TGI doesn't support such configuration. Please implement options like --prometheus-port and --prometheus-addr (the latter is not important to me).

Motivation

This feature being missing is quite problematic for me, as I'm on a system where I cannot create an isolated network and port 9000 is already in use. This results in the failed to build prometheus recorder from TGI.

Your contribution

I've contributed with specific guidance, and I've made made major contributions to other huggingface projects. However, I'm presently not strong enough in Rust to do this well.

References:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant