Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why you say it's not needed to run the models pruned by the nn_pruning tools? #23

Open
luofuli opened this issue Jun 8, 2021 · 1 comment

Comments

@luofuli
Copy link

luofuli commented Jun 8, 2021

In the README.md, why did you say that "it's not needed to run the models pruned by the nn_pruning tools"?

@madlag
Copy link
Contributor

madlag commented Oct 21, 2021

The nn_pruning tool remove entire heads in attention and entire rows/columns in feed forward networks. The remaining heads are then pretty dense, and the feed forward networks are completely dense after row/column removal.
That means that pytorch_block_sparse is not fast enough for this slightly sparse network to be competitive with very efficient standard dense linear algebra kernels: there are not enough zeros for pytorch_block_sparse to be competitive, so just using standard pytorch functions is faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants