From 018545f1d08cf250d399f75768293b4b2e25a7c7 Mon Sep 17 00:00:00 2001
From: Hugo Larcher <hugo.larcher@huggingface.co>
Date: Tue, 25 Feb 2025 15:44:32 +0100
Subject: [PATCH] fix: PR comment, use join()

---
 src/api/sync.rs  | 12 +++++++-----
 src/api/tokio.rs | 12 +++++++-----
 2 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/src/api/sync.rs b/src/api/sync.rs
index 4f09ed4..e2592a1 100644
--- a/src/api/sync.rs
+++ b/src/api/sync.rs
@@ -317,11 +317,13 @@ impl ApiBuilder {
 
     fn build_headers(&self) -> HeaderMap {
         let mut headers = HeaderMap::new();
-        let mut user_agent = "".to_string();
-        self.user_agent.iter().for_each(|(key, value)| {
-            user_agent = format!("{user_agent}; {key}/{value}");
-        });
-        headers.insert(USER_AGENT, user_agent[2..].to_string());
+        let user_agent = self
+            .user_agent
+            .iter()
+            .map(|(key, value)| format!("{key}/{value}"))
+            .collect::<Vec<_>>()
+            .join("; ");
+        headers.insert(USER_AGENT, user_agent.to_string());
         if let Some(token) = &self.token {
             headers.insert(AUTHORIZATION, format!("Bearer {token}"));
         }
diff --git a/src/api/tokio.rs b/src/api/tokio.rs
index 7d5419a..7f88eff 100644
--- a/src/api/tokio.rs
+++ b/src/api/tokio.rs
@@ -342,11 +342,13 @@ impl ApiBuilder {
 
     fn build_headers(&self) -> Result<HeaderMap, ApiError> {
         let mut headers = HeaderMap::new();
-        let mut user_agent = "".to_string();
-        self.user_agent.clone().iter().for_each(|(key, value)| {
-            user_agent = format!("{user_agent}; {key}/{value}");
-        });
-        headers.insert(USER_AGENT, HeaderValue::from_str(&user_agent[2..])?);
+        let user_agent = self
+            .user_agent
+            .iter()
+            .map(|(key, value)| format!("{key}/{value}"))
+            .collect::<Vec<_>>()
+            .join("; ");
+        headers.insert(USER_AGENT, HeaderValue::from_str(&user_agent)?);
         if let Some(token) = &self.token {
             headers.insert(
                 AUTHORIZATION,