Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GaussDB): change huaweicloud_gaussdb_opengauss_limit_sql_models to huaweicloud_gaussdb_opengauss_sql_templates #6323

Conversation

houpeng80
Copy link
Collaborator

What this PR does / why we need it:
change huaweicloud_gaussdb_opengauss_limit_sql_models to huaweicloud_gaussdb_opengauss_sql_templates
Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

  change huaweicloud_gaussdb_opengauss_limit_sql_models to huaweicloud_gaussdb_opengauss_sql_templates

PR Checklist

  • Tests added/passed.
make testacc TEST=./huaweicloud/services/acceptance/gaussdb/ TESTARGS='-run TestAccDataSourceGaussdbOpengaussSqlTemplates_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/gaussdb/ -v -run TestAccDataSourceGaussdbOpengaussSqlTemplates_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceGaussdbOpengaussSqlTemplates_basic
=== PAUSE TestAccDataSourceGaussdbOpengaussSqlTemplates_basic
=== CONT  TestAccDataSourceGaussdbOpengaussSqlTemplates_basic
--- PASS: TestAccDataSourceGaussdbOpengaussSqlTemplates_basic (56.05s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/gaussdb   56.097s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

…to huaweicloud_gaussdb_opengauss_sql_templates
@Jason-Zhang9309
Copy link
Collaborator

/lgtm
/approve

@github-ci-robot github-ci-robot added the LGTM /lgtm label Feb 14, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Jason-Zhang9309

/lgtm
/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2025
@github-ci-robot github-ci-robot merged commit 7c288c9 into huaweicloud:master Feb 14, 2025
14 checks passed
@houpeng80 houpeng80 deleted the fix_gaussdb_opengauss_sql_templates branch February 14, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants