Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(hss): refactor webtamper_hosts data source code style #6281

Conversation

jinyangyang222
Copy link
Contributor

@jinyangyang222 jinyangyang222 commented Feb 8, 2025

What this PR does / why we need it:

refactor webtamper_hosts data source code style

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


refactor webtamper_hosts data source code style

PR Checklist

  • Tests added/passed.
$ export HW_HSS_HOST_PROTECTION_HOST_ID=xxxxxxxxxxxxxx

$ make testacc TEST="./huaweicloud/services/acceptance/hss" TESTARGS="-run TestAccDataSourceWebTamperHosts_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/hss -v -run TestAccDataSourceWebTamperHosts_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceWebTamperHosts_basic
=== PAUSE TestAccDataSourceWebTamperHosts_basic
=== CONT  TestAccDataSourceWebTamperHosts_basic
--- PASS: TestAccDataSourceWebTamperHosts_basic (163.42s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/hss       163.462s

image

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@deer-hang
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Feb 10, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

/approve
/lgtm

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2025
@github-ci-robot github-ci-robot merged commit d226294 into huaweicloud:master Feb 10, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. LGTM /lgtm refactor size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants