Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect repeating a song #52

Merged
merged 1 commit into from
Sep 30, 2018
Merged

detect repeating a song #52

merged 1 commit into from
Sep 30, 2018

Conversation

ninavdl
Copy link
Contributor

@ninavdl ninavdl commented Sep 17, 2018

Should fix #20.

I assume a song is being played again if the position in the song changes from >50% of the length of the song to the first 10 seconds of the song

@hrkfdn
Copy link
Owner

hrkfdn commented Sep 18, 2018

Hey! Thanks for the patch, it's been an issue bugging many for a long time and I never got around to fix it as I don't use Last.fm that often anymore.

Couple of questions:

  • When or why does the client return an empty song object?
  • Have you looked at how other scrobblers deal with this problem?

@ninavdl
Copy link
Contributor Author

ninavdl commented Sep 23, 2018

When or why does the client return an empty song object?

I'm actually not sure if that ever happens, but I wanted to be safe

Have you looked at how other scrobblers deal with this problem?

I have looked into github.com/hawx/mpd-scrobbler, which doesn not seem to handle this problem.

@hrkfdn hrkfdn merged commit c8ba5f1 into hrkfdn:master Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated play only scribbled once
2 participants