Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralise Redis service? #38

Open
neanias opened this issue Dec 9, 2017 · 4 comments
Open

Centralise Redis service? #38

neanias opened this issue Dec 9, 2017 · 4 comments

Comments

@neanias
Copy link
Collaborator

neanias commented Dec 9, 2017

The redis variable seems to be instantiated quite a few times in different places. Maybe centralise it in the botbot init file?
@hreeder
Copy link
Owner

hreeder commented Dec 11, 2017

Could be an idea. Does redis require us to perform a keepalive or similar while the connection is open?

@neanias
Copy link
Collaborator Author

neanias commented Dec 11, 2017

https://media.giphy.com/media/XeXzWgD6P4LG8/giphy.gif

@hreeder
Copy link
Owner

hreeder commented Dec 11, 2017

Looking at redis-py's documentation, there's stuff in there for keepalives / retry on timeout, so this may be straight forward.

@neanias
Copy link
Collaborator Author

neanias commented Dec 11, 2017

Schweet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hreeder @neanias