Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug logging cannot be disabled and SSH logs are not enabled when passing debug=True on client init #76

Open
Akrog opened this issue May 29, 2020 · 0 comments · May be fixed by #77
Open

Debug logging cannot be disabled and SSH logs are not enabled when passing debug=True on client init #76

Akrog opened this issue May 29, 2020 · 0 comments · May be fixed by #77

Comments

@Akrog
Copy link

Akrog commented May 29, 2020

Contrary to what the docstring says, debug logs cannot be disabled:

    def set_debug_flag(self, flag):
       """
       This turns on/off http request/response debugging output to console

And if we enable debug logs on the client on initialization via the debug parameter then SSH logs will not be enabled.
Akrog added a commit to Akrog/python-3parclient that referenced this issue May 29, 2020
@Akrog
Fix debug logging
f0ec38f 
We currently have a couple of issues with the enabling and disabling of
debug logs:

- Passing "debug=True" on client creation will not output ssh logs.

- Once enabled, SSH and HTTP debug logs cannot be disabled.

This patch fixes the first issue by making "set_debug_flag" as class
methods and always calling ssh's "set_debug_flag", unlike now that we
only call it when the ssh instance has already been created.

For the second issue we add the missing disabling code in both
"set_debug_flag" methods.

Closes hpe-storage#76
@Akrog Akrog linked a pull request May 29, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix debug logging Akrog/python-3parclient
1 participant
@Akrog