From 6831c364e3bad89b9a84629877905924a36fb5b7 Mon Sep 17 00:00:00 2001
From: amansinghbais <singh11amanbais@gmail.com>
Date: Mon, 27 Jan 2025 11:17:33 +0530
Subject: [PATCH 1/2] Fixed: click event to toggle assocition of facility group
 to parent not working on clicking on label (#342)

---
 src/views/FindGroups.vue | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/views/FindGroups.vue b/src/views/FindGroups.vue
index 82b15d4..fc6ad50 100644
--- a/src/views/FindGroups.vue
+++ b/src/views/FindGroups.vue
@@ -79,8 +79,8 @@
               <ion-list-header>
                 <ion-label>{{ translate('Selected groups') }} : {{ getAssociatedFacilityGroupIds(currentFacilityGroupTypeId).length }}</ion-label>
               </ion-list-header>
-              <ion-item v-for="group in groups" :key="group.facilityGroupId">
-                <ion-checkbox label-placement="end" justify="start" :disabled="!!group.facilityGroupTypeId && group.facilityGroupTypeId !== currentFacilityGroupTypeId" :checked="isFacilityGroupLinked(group.facilityGroupTypeId)" @click="updateFacilityGroup($event, group)">
+              <ion-item v-for="group in groups" :key="group.facilityGroupId" @click.stop="updateFacilityGroup(group)">
+                <ion-checkbox label-placement="end" justify="start" :disabled="!!group.facilityGroupTypeId && group.facilityGroupTypeId !== currentFacilityGroupTypeId" :checked="isFacilityGroupLinked(group.facilityGroupTypeId)">
                   <ion-label>
                     {{ group.facilityGroupName }}
                     <p>{{ group.facilityGroupId }}</p>
@@ -215,10 +215,8 @@ export default defineComponent({
     isFacilityGroupLinked(facilityGroupTypeId: any) {
       return this.currentFacilityGroupTypeId === facilityGroupTypeId
     },
-    async updateFacilityGroup(event: any, facilityGroup: any) {
-      event.preventDefault();
-      event.stopImmediatePropagation();
-      const isChecked = !event.target.checked;
+    async updateFacilityGroup(facilityGroup: any) {
+      const isChecked = !this.isFacilityGroupLinked(facilityGroup.facilityGroupTypeId);
       try {
         const resp = await FacilityService.updateFacilityGroup({
           "facilityGroupId": facilityGroup.facilityGroupId,

From da99d9d7310d13ee2e9623e676e7d3257b9d94c0 Mon Sep 17 00:00:00 2001
From: amansinghbais <singh11amanbais@gmail.com>
Date: Mon, 27 Jan 2025 11:20:03 +0530
Subject: [PATCH 2/2] Improved: used modelValue instead of checked for showing
 checkbox status (#342)

---
 src/views/FindGroups.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/views/FindGroups.vue b/src/views/FindGroups.vue
index fc6ad50..c783248 100644
--- a/src/views/FindGroups.vue
+++ b/src/views/FindGroups.vue
@@ -80,7 +80,7 @@
                 <ion-label>{{ translate('Selected groups') }} : {{ getAssociatedFacilityGroupIds(currentFacilityGroupTypeId).length }}</ion-label>
               </ion-list-header>
               <ion-item v-for="group in groups" :key="group.facilityGroupId" @click.stop="updateFacilityGroup(group)">
-                <ion-checkbox label-placement="end" justify="start" :disabled="!!group.facilityGroupTypeId && group.facilityGroupTypeId !== currentFacilityGroupTypeId" :checked="isFacilityGroupLinked(group.facilityGroupTypeId)">
+                <ion-checkbox label-placement="end" justify="start" :disabled="!!group.facilityGroupTypeId && group.facilityGroupTypeId !== currentFacilityGroupTypeId" :modelValue="isFacilityGroupLinked(group.facilityGroupTypeId)">
                   <ion-label>
                     {{ group.facilityGroupName }}
                     <p>{{ group.facilityGroupId }}</p>