From bb03f7c41a89ff4a2f71c0e58091b7246358b3dd Mon Sep 17 00:00:00 2001
From: Michal Horejsek <michal@horejsek.com>
Date: Sun, 16 Jun 2024 19:33:20 +0200
Subject: [PATCH] Improved regexp for ipv4 format to comfort test suite

---
 CHANGELOG.txt                       | 1 +
 fastjsonschema/draft04.py           | 2 +-
 tests/json_schema/test_draft04.py   | 1 -
 tests/json_schema/test_draft06.py   | 1 -
 tests/json_schema/test_draft07.py   | 2 +-
 tests/json_schema/test_draft2019.py | 1 -
 6 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/CHANGELOG.txt b/CHANGELOG.txt
index 25a25d8..db53c99 100644
--- a/CHANGELOG.txt
+++ b/CHANGELOG.txt
@@ -6,6 +6,7 @@
 * Fixed that everything with empty `not` is invalid
 * Improved regexp for email format to comfort test suite
 * Improved regexp for date format to comfort test suite
+* Improved regexp for ipv4 format to comfort test suite
 
 === 2.20.0 (2024-06-15)
 
diff --git a/fastjsonschema/draft04.py b/fastjsonschema/draft04.py
index cf6cd8f..e4cf74a 100644
--- a/fastjsonschema/draft04.py
+++ b/fastjsonschema/draft04.py
@@ -29,7 +29,7 @@ class CodeGeneratorDraft04(CodeGenerator):
         'date-time': r'^\d{4}-[01]\d-[0-3]\d(t|T)[0-2]\d:[0-5]\d:[0-5]\d(?:\.\d+)?(?:[+-][0-2]\d:[0-5]\d|[+-][0-2]\d[0-5]\d|z|Z)\Z',
         'email': r'^(?!.*\.\..*@)[^@.][^@]*(?<!\.)@[^@]+\.[^@]+\Z',
         'hostname': r'^(([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\-]{0,61}[a-zA-Z0-9])\.)*([A-Za-z0-9]|[A-Za-z0-9][A-Za-z0-9\-]{0,61}[A-Za-z0-9])\Z',
-        'ipv4': r'^((25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){3}(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\Z',
+        'ipv4': r'^((25[0-5]|2[0-4][0-9]|1?[0-9][0-9]?)\.){3}(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\Z',
         'ipv6': r'^(?:(?:[0-9A-Fa-f]{1,4}:){6}(?:[0-9A-Fa-f]{1,4}:[0-9A-Fa-f]{1,4}|(?:(?:[0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])\\.){3}(?:[0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5]))|::(?:[0-9A-Fa-f]{1,4}:){5}(?:[0-9A-Fa-f]{1,4}:[0-9A-Fa-f]{1,4}|(?:(?:[0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])\\.){3}(?:[0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5]))|(?:[0-9A-Fa-f]{1,4})?::(?:[0-9A-Fa-f]{1,4}:){4}(?:[0-9A-Fa-f]{1,4}:[0-9A-Fa-f]{1,4}|(?:(?:[0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])\\.){3}(?:[0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5]))|(?:[0-9A-Fa-f]{1,4}:[0-9A-Fa-f]{1,4})?::(?:[0-9A-Fa-f]{1,4}:){3}(?:[0-9A-Fa-f]{1,4}:[0-9A-Fa-f]{1,4}|(?:(?:[0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])\\.){3}(?:[0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5]))|(?:(?:[0-9A-Fa-f]{1,4}:){,2}[0-9A-Fa-f]{1,4})?::(?:[0-9A-Fa-f]{1,4}:){2}(?:[0-9A-Fa-f]{1,4}:[0-9A-Fa-f]{1,4}|(?:(?:[0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])\\.){3}(?:[0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5]))|(?:(?:[0-9A-Fa-f]{1,4}:){,3}[0-9A-Fa-f]{1,4})?::[0-9A-Fa-f]{1,4}:(?:[0-9A-Fa-f]{1,4}:[0-9A-Fa-f]{1,4}|(?:(?:[0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])\\.){3}(?:[0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5]))|(?:(?:[0-9A-Fa-f]{1,4}:){,4}[0-9A-Fa-f]{1,4})?::(?:[0-9A-Fa-f]{1,4}:[0-9A-Fa-f]{1,4}|(?:(?:[0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])\\.){3}(?:[0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5]))|(?:(?:[0-9A-Fa-f]{1,4}:){,5}[0-9A-Fa-f]{1,4})?::[0-9A-Fa-f]{1,4}|(?:(?:[0-9A-Fa-f]{1,4}:){,6}[0-9A-Fa-f]{1,4})?::)\Z',
         'uri': r'^\w+:(\/?\/?)[^\s]+\Z',
     }
diff --git a/tests/json_schema/test_draft04.py b/tests/json_schema/test_draft04.py
index 25e6ea8..711b788 100644
--- a/tests/json_schema/test_draft04.py
+++ b/tests/json_schema/test_draft04.py
@@ -21,7 +21,6 @@ def pytest_generate_tests(metafunc):
             'enum.json',
 
             # TODO: fix formats
-            'ipv4.json',
             'ipv6.json',
             'time.json',
             'format.json',
diff --git a/tests/json_schema/test_draft06.py b/tests/json_schema/test_draft06.py
index 4566ee6..a5281e7 100644
--- a/tests/json_schema/test_draft06.py
+++ b/tests/json_schema/test_draft06.py
@@ -21,7 +21,6 @@ def pytest_generate_tests(metafunc):
             'enum.json',
 
             # TODO: fix formats
-            'ipv4.json',
             'ipv6.json',
             'time.json',
             'format.json',
diff --git a/tests/json_schema/test_draft07.py b/tests/json_schema/test_draft07.py
index 444d686..bca18d4 100644
--- a/tests/json_schema/test_draft07.py
+++ b/tests/json_schema/test_draft07.py
@@ -24,7 +24,7 @@ def pytest_generate_tests(metafunc):
             'enum.json',
 
             # TODO: fix formats
-            'ipv4.json',
+            #'ipv4.json',
             'ipv6.json',
             'time.json',
             'format.json',
diff --git a/tests/json_schema/test_draft2019.py b/tests/json_schema/test_draft2019.py
index 1121e7a..0919d65 100644
--- a/tests/json_schema/test_draft2019.py
+++ b/tests/json_schema/test_draft2019.py
@@ -24,7 +24,6 @@ def pytest_generate_tests(metafunc):
             'enum.json',
 
             # TODO: fix formats
-            'ipv4.json',
             'ipv6.json',
             'time.json',
             'format.json',