BugFix: Fixing paper-dialog-scrollable clipping on IOS #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciotlosm
changed the title
lucasweb78
approved these changes
Feb 7, 2018
There was a problem hiding this comment.
The change LGTM to me. I've tested locally and it resolves the problem. I did do a little research and it seems this is needed when -webkit-overflow-scrolling: touch; is set on paper-scroll-header-panel which is the case for this dialog. I couldn't find a reason why this is needed but there are several discussion about this including PolymerElements/paper-dialog#7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
#775
Potentially also fixes:
home-assistant/core#6285
#841
#372
Might also be helpful for #779 if someone wants to try and adapt the fix.
Note: Thanks to @cristianbote that provided the fix