-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FutureWarning: functools.partial will be a method descriptor in future Python versions; (MIIO) #132902
Comments
Hey there @rytilahti, @syssi, @starkillerOG, mind taking a look at this issue as it has been labeled with an integration ( Code owner commandsCode owners of
(message by CodeOwnersMention) xiaomi_miio documentation |
py3.13 started to print out this warning, this needs to be fixed in upstream but I'm not sure what's the best approach, when a new release will get done, etc. If anyone has an idea, feel free to open a PR: https://github.com/rytilahti/python-miio/ |
Home Assistant v2025.1.0. Logger: py.warnings /usr/local/lib/python3.13/site-packages/miio/miot_device.py:23: FutureWarning: functools.partial will be a method descriptor in future Python versions; wrap it in enum.member() if you want to preserve the old behavior Bool = partial(_str2bool) |
Yes, that's the same message as in the original post. Upstream PR has already been merged, so this pends only on a new python-miio release. Ref. rytilahti/python-miio#1993 |
I understood these messages should disappear with v2025.1.1, however I am a still seeing this after updating. Did I misunderstood and some other component needs to be updated as well? |
|
It's miio on my side and the logger doesn't report it as custom:
|
As far as I understand the fix has been done in the upstream project, but there is no new release of |
Exactly. A python-miio release is required. |
Same here.
So, I am waiting for the python-miio release. Thanks |
@rytilahti Would it make sense to release a minor version to fix this soon? |
@TheZoker First of all, thanks for the ping! Given the current fix requires a version bump anyway, I might very well just make a new release to avoid branching for a minor release as having multiple branches to maintain doesn't really help with the maintenance of a barely-maintained project. I am not able to contribute much time for this at the moment, but I can offer to do a new dev release containing the already merged fix, hoping that someone will help me to take a look into getting necessary changes into the integration to avoid breaking changes. There should not be that many breaking changes, but bumping this dependency will still require someone to test it as I don't want to break existing installations for just suppressing this warning caused by a python update. So, if some willing developer with access to devices supported by this integration wants to contribute and get this done, I'm happy to be around to make it happen. The first step would to to see if upgrading to |
@rytilahti just bumped into this issue, I only have a Xiaomi Aqara Gateway but I will test bumping to |
@thecode thanks! There are likely some breaking changes (or at least ones that will cause deprecation warnings), the problem being that there's no proper test coverage given how old the integration code base is. When you do give it a test, let me know if something breaks and we'll figure out a solution for that. There has been some changes since the dev0, so you may want to give the master also a try. I will try to do my best to have some time to get a |
This error happens running on the master branch
It will happens on tests also. I think the first step would be to make a release than start to work on adjusting the breaking changes, hopefully they are listed on the release notes. |
Same here.
|
It is strange for me that this error appears in my logs but I don't even have this Integration installed. Why? |
Please don't spam the issue with "Same here", the owner is aware of it and working to fix it. It is enough to put 👍 on the first post |
the problem is that this error appears also for me when i dont have installed xiaomi-miot custom component ( i had but uninstalled it and clean all i was able to). so why i still recevied this error? |
Any updates on this topic? Thanks. |
I'm in the same situation, so I wanted to report what I tried to do, without success of course, but maybe someone could find theese informations useful for a better understanding. I once had a xiaomi robot installed, but turned to Valetudo, which should not use anything from the older integration, which I removed. So, So, So, In my very ignorant opinion, there's still something somewhere that tries to activate the integration and I'd like to know if and where this starter is. Thank you all |
Ditto to @Innominatapersona, had xiaomi robot, moved it to Valetudo/mqtt. But HA still has some kind of cling to miio |
The problem
What version of Home Assistant Core has the issue?
core-2024.12.3
What was the last working version of Home Assistant Core?
core-2024.11.3
What type of installation are you running?
Home Assistant Core
Integration causing the issue
xiaomi_miio
Link to integration documentation on our website
https://www.home-assistant.io/integrations/miio/
Diagnostics information
config_entry-xiaomi_miio-f27bed13443433d5a9f222756176190d.json
Example YAML snippet
No response
Anything in the logs that might be useful for us?
Additional information
No response
The text was updated successfully, but these errors were encountered: