From d93fec4110af7b99b1bf2709c73496b14790028f Mon Sep 17 00:00:00 2001 From: Simon Zambrovski Date: Wed, 11 Oct 2023 11:42:05 +0200 Subject: [PATCH] improve tests, remove warnings --- .../view/jpa/JpaPolyflowViewServiceDataEntryITest.kt | 1 + .../view/jpa/JpaPolyflowViewServiceTaskITest.kt | 11 ++++++----- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/view/jpa/src/test/kotlin/io/holunda/polyflow/view/jpa/JpaPolyflowViewServiceDataEntryITest.kt b/view/jpa/src/test/kotlin/io/holunda/polyflow/view/jpa/JpaPolyflowViewServiceDataEntryITest.kt index 21f913b62..5b9ef5f3b 100644 --- a/view/jpa/src/test/kotlin/io/holunda/polyflow/view/jpa/JpaPolyflowViewServiceDataEntryITest.kt +++ b/view/jpa/src/test/kotlin/io/holunda/polyflow/view/jpa/JpaPolyflowViewServiceDataEntryITest.kt @@ -313,6 +313,7 @@ internal class JpaPolyflowViewServiceDataEntryITest { assertThat(result.payload.elements.map { it.entryId }).containsExactly(id2, id, id4) } + @Suppress("DEPRECATION") @Test fun `sort should be backwards compatible`() { diff --git a/view/jpa/src/test/kotlin/io/holunda/polyflow/view/jpa/JpaPolyflowViewServiceTaskITest.kt b/view/jpa/src/test/kotlin/io/holunda/polyflow/view/jpa/JpaPolyflowViewServiceTaskITest.kt index 4e94ae1b5..a76bbb71b 100644 --- a/view/jpa/src/test/kotlin/io/holunda/polyflow/view/jpa/JpaPolyflowViewServiceTaskITest.kt +++ b/view/jpa/src/test/kotlin/io/holunda/polyflow/view/jpa/JpaPolyflowViewServiceTaskITest.kt @@ -299,12 +299,13 @@ internal class JpaPolyflowViewServiceTaskITest { sort = listOf() )) - val sortWithSortNutSuppliedQuery = jpaPolyflowViewService.query(AllTasksWithDataEntriesQuery()) + val sortWithSortNotSuppliedQuery = jpaPolyflowViewService.query(AllTasksWithDataEntriesQuery()) - assertThat(sortWithEmptyStringQuery.elements).isEqualTo(sortWithSortNutSuppliedQuery.elements) - assertThat(sortWithSortNutSuppliedQuery.elements).isEqualTo(sortWithEmptyListQuery.elements) - assertThat(sortWithEmptyListQuery.elements).isEqualTo(sortWithEmptyStringQuery.elements) - assertThat(sortWithSortNutSuppliedQuery.elements).isEqualTo(sortWithEmptyStringQuery.elements) + + assertThat(sortWithNullQuery.elements).isEqualTo(sortWithEmptyStringQuery.elements) + assertThat(sortWithEmptyStringQuery.elements).isEqualTo(sortWithEmptyListQuery.elements) + assertThat(sortWithEmptyListQuery.elements).isEqualTo(sortWithSortNotSuppliedQuery.elements) + assertThat(sortWithSortNotSuppliedQuery.elements).isEqualTo(sortWithNullQuery.elements) } @Test