Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Broken retrocompatibility with serialized images #334

Open
saif-ellafi opened this issue Jan 24, 2025 · 3 comments
Open

[Bug]: Broken retrocompatibility with serialized images #334

saif-ellafi opened this issue Jan 24, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@saif-ellafi
Copy link
Contributor

Package Version

8.0.0

Flutter Version

3.27.3

Platforms

iOS, Android, Web, macOS, Windows, Linux

How to reproduce?

Some images are getting stuck in "Changes are being applied" forever, the editor never closes to save and finish.

What I noticed:
The images crashing, were ones from before 7.x.x with serialized stickers inside. At 7.x.x they were still working, retrocompatible.

For some reason now at version 8, serialized images now fully disappear after the first save. Further state load and save gets stuck in "Changes are being applied" forever when saving, with the Sticker completely gone or replaced with a Text Widget in Red.

I would need to continue investigating further, but this does not happen with Stickers that were not serialized and metadata was included, only with pre <7.0.0 serialized images.

Is this expected?

Thanks!

Logs (optional)

Example code (optional)

Device Model (optional)

No response

@saif-ellafi saif-ellafi added the bug Something isn't working label Jan 24, 2025
@saif-ellafi
Copy link
Contributor Author

I have the gut feeling the library is having an issue when trying to save a Sticker that was serialized in the State, it seems to be failing to generate a new image.

@hm21
Copy link
Owner

hm21 commented Jan 25, 2025

That sounds interesting! I’ll take a look at it. Do you maybe have a demo JSON history that I could use to test it directly?

@saif-ellafi
Copy link
Contributor Author

saif-ellafi commented Jan 25, 2025

@hm21 here they are (1. generated image, 2. base image, 3. history file for State, and 4. the image representing the sticker that was serialized)

Image

Image

Image

history_bc8r5c0d4q_Kleigan_zrf8stjmxb_FATE Core Sheet.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants