Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA 5.0.0 Release Branch #936

Open
dt-r opened this issue Jan 13, 2025 · 3 comments
Open

QA 5.0.0 Release Branch #936

dt-r opened this issue Jan 13, 2025 · 3 comments

Comments

@dt-r
Copy link
Collaborator

dt-r commented Jan 13, 2025

UPDATED 15/01

  1. In QA.html:
    • Supress Slicing Information - $\color{green}{\textsf{DONE}}$
    • Suppress Information - $\color{green}{\textsf{DONE}}$
    • Editorial note required for all extant errors, e.g. "Unknown code '11815W' in the CodeSystem 'http://pbs.gov.au/code/item' (from https://tx.ontoserver.csiro.au/fhir, see log)" - $\color{red}{\textsf{NOT DONE}}$
    • Supress all warnings, none are problems with the structure in current QA.html - only some are new and need to be approved in next FHIR WG - $\color{red}{\textsf{NOT DONE}}$
  2. Change log needs the agreed improvements relating to sub headings with an intro sentence for the following:
    • breaking changes - $\color{green}{\textsf{DONE}}$
    • items not included cause publication policy - $\color{green}{\textsf{DONE}}$
    • changes in this version - $\color{green}{\textsf{DONE}}$
  3. Change log entry for 5.0.0 - do not hyperlink artefacts to current build, those items may or may not ever be published. Instead have an intro sentence (that links to current build ig) and tells people to check for current state. - $\color{green}{\textsf{DONE}}$
  4. Change log publication date for 5.0.0 - change to be 15 Jan, cause that's when we are going for approval and actual publication - $\color{green}{\textsf{DONE}}$
  5. Change log 5.0.0 list of draft artefacts not included is missing the following (also fix spelling to be 'artefacts': - $\color{green}{\textsf{DONE}}$
    • Vaccine Vial Serial Number extension
    • Observation Category Codes - AU Extended value set
    • Observation Category Codes AU code system
    • Medication Strength extension
  6. Change log style - Where an artefact has only one change it doesn't have a parent and child bullet point. The following still needs to be refactored to be single entries in the change log: - $\color{green}{\textsf{DONE}}$ $\color{orange}{\textsf{The list style is poor because it takes up twice the space it needs to due to use of parent/child bullet points however it is consistent. Improvements will be held to next release.}}$
  1. Future of AU Base - the image for yearly updates hasn't updated the version number. @dt-r to do this in ci build - FIXED in CI, TO DO in 5.0.0 - $\color{green}{\textsf{DONE}}$
  2. Expectation that healthterminologies terminology in profiles goes to NCTS not tx.csiro so that terminology coming from AU doesn't look strange compared to terminology from HL7 Terminology - this was discussed with Reuben as something that may have to be manually done if the tooling fix hadn't yet been applied. $\color{red}{\textsf{NOT DONE}}$
  3. STU Note on https://build.fhir.org/ig/hl7au/au-fhir-base/branches/5.0.0/StructureDefinition-au-encounter.html & https://build.fhir.org/ig/hl7au/au-fhir-base/branches/5.0.0/ValueSet-au-v3-ActEncounterCode-extended.html: don't say "These are defined as child concepts of the VR ActEncounterCode", because that implies that these are formally defined as such and they are not. Instead just state that they 'are' or 'agreed to be' child concepts of the VR ActEncounterCode. In addition, I would recommend using 'value set' instead of 'ValueSet' and 'code system' instead of 'CodeSystem' in keeping with AU Base style. - $\color{green}{\textsf{DONE}}$
  4. Applies to all breaking change STU Notes:
    • qualify that this is for this version (we don't maintain these). Can do this by either appending to the heading 'in 5.0.0' or 'from 4.1.0' or by adjusting the first sentence to state "Implementers should note version 5.0.0 of AU Base ..." - $\color{green}{\textsf{DONE}}$
    • add a link to the change log subsection with the full list of breaking changes in this release (after implementing fix for point 2) - $\color{green}{\textsf{DONE}}$
  5. Remove the following draft artefacts (Incl from Terminology page):
    • Observation Category Codes - AU Extended value set
    • Observation Category Codes AU code system
@dbojicic
Copy link
Collaborator

dbojicic commented Jan 13, 2025

DB comments:

  1. AU Base Yearly Updates, Figure 1 should be updated to reflect on the version change, e.g. shows 'Publication of AU Base 4.2.0'
  2. Terminology page has some formatting issues that results in page not being rendered properly,
    • e.g. "<a href="AU Base Medication Request" in the ValueSets table
    • heading for CodeSystems table is not displayed properly
    • Concept Maps section
  3. AU Local Order Identifier - 'placer identifier' and 'filler identifier' links in the description point out the old Confluence page and result in 'This site can’t be reached' error. Fix should be applied in CI build as well. - DONE
  4. AU Care Medicare Card Number STU Note - DONE
    • the text 'AU Care Medicare Card Number' is hyperlinked to the same page, remove the hyperlink
    • Consider adding 'that' so that the note reads 'Implementers should note that the ...'
    • Change 'can not' to 'cannot'
    • Consider changing 'less than digit 10 digit forms of Medicare Number ' to 'forms of Medicare Numbers with fewer than 10 digits'
  5. AU Base Diagnostic Result STU Note - NOT DONE
    • remove hyperlink from 'AU Base Diagnostic Result' that points to the same page
    • update the hyperlink text for the BodyStructure Reference to match the implementation guidance text & the extension name
    • remove 'element' after 'Observation.bodySite' to align with AU Base conventions
      so it becomes something like

Implementers should note that the use of the BodyStructure Reference extension and the FHIR R4 Observation.bodySite are now mutually exclusive in the AU Base Diagnostic Result. This change aligns with future constraints in the FHIR R5 Observation resource and ensures the source of the related body site is unambiguous.

@dt-r dt-r changed the title QA 5.0.0 (DTR) QA 5.0.0 Release Branch Jan 14, 2025
@brettesler-ext
Copy link
Collaborator

Remaining

  • AU Base Yearly Updates, Figure 1 should be updated to reflect on the version change, e.g. shows 'Publication of AU Base 4.2.0'
  • Future of AU Base - the image for yearly updates hasn't updated the version number. @dt-r to do this in ci build - FIXED in CI, TO DO in 5.0.0
  • Expectation that healthterminologies terminology in profiles goes to NCTS not tx.csiro so that terminology coming from AU doesn't look strange compared to terminology from HL7 Terminology - this was discussed with Reuben as something that may have to be manually done if the tooling fix hadn't yet been applied.

tx.csrio has a fault and there are numerous validation errors; pinged the CSIRO crew was ok until about 5pm Tue then started failing

@dt-r
Copy link
Collaborator Author

dt-r commented Jan 14, 2025

@brettesler-ext - AU Base Yearly Updates / Future of AU Base, Figure 1 is fixed, it came in when you merged master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants