Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Configuration Option for Dollar-Topic Publishing #567

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Feature: Configuration Option for Dollar-Topic Publishing #567

wants to merge 12 commits into from

Conversation

Z0rdak
Copy link

@Z0rdak Z0rdak commented Feb 12, 2025

Motivation

I've described the motivation in my previous created issue, but never got an response.

Please let me know if any further changes need to be done.

Resolves #523

Changes

In short: Removed old internal constant to allow clients to publish to dollar topics and replaced it with a XML configuration entry.

Listed changes mostly reflect commits:

  • add new boolean configuration for allow-dollar-topics
  • add constant for allow-dollar-topic default value
  • extend MqttConfigurationService interface with getter and setter for new config option
  • add implementation for new interface methods
  • add config entity entry to MqttConfigurator
  • adapt tests to include new config entity
  • remove old internal configuration option constant
  • add MqttConfigurationService as argument to PluginAuthorizerService
  • adapt PluginAuthorizerService test

Z0rdak added 12 commits February 11, 2025 13:11
@cla-bot cla-bot
Copy link

cla-bot bot commented Feb 12, 2025

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @Z0rdak on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@Z0rdak
Copy link
Author

Z0rdak commented Feb 12, 2025

Just signed the Contributor License Agreement. My bad. :-)

@Z0rdak Z0rdak changed the title Feature/allow dollar topics config Feature: Configuration Option for Dollar-Topic Publishing Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce XML Configuration Option for Dollar-Topic Publishing
1 participant
@Z0rdak