Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid Types for requestAvailablePaymentProduct #1

Open
paul-vd opened this issue Jan 7, 2025 · 0 comments · May be fixed by #2
Open

Invalid Types for requestAvailablePaymentProduct #1

paul-vd opened this issue Jan 7, 2025 · 0 comments · May be fixed by #2

Comments

@paul-vd
Copy link

paul-vd commented Jan 7, 2025 •
edited
Loading

Firstly, it would be beneficial to generate TypeScript declarations. The only way to get this package to infer the JSDoc types in a TypeScript project is to explicitly include "node_modules/@hipay/hipay-enterprise-sdk-nodejs/**/*.js" in the tsconfig. By 2025, it is standard practice have type declarations for distributed packages.

Issue

The parameters for requestAvailablePaymentProduct should be typed as AvailablePaymentProductRequest | | ConstructorParameters<typeof AvailablePaymentProductRequest>[0] instead of String.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@paul-vd