Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #17677 to use EntityIdFactory instead of depending on the HederaConfig #17878

Closed
vtronkov opened this issue Feb 13, 2025 · 1 comment
Closed

Refactor #17677 to use EntityIdFactory instead of depending on the HederaConfig #17878

vtronkov opened this issue Feb 13, 2025 · 1 comment
Assignees
@vtronkov
Milestone
v0.60

Comments

@vtronkov
Copy link
Contributor

vtronkov commented Feb 13, 2025 •
edited
Loading

Our initial implementation of the epic was to get access to HederaConfig and get the shard/realm from there. Michael T. created this story #17822 introducing EntityIdFactory that encasulates the creation of entities with the correct shard/realm.

Get through the changes in #17677 and refactor them to use the new EntityIdFactory objects instead of relying directly on HederaConfig:
@vtronkov vtronkov changed the title Refactor #17677 to use EntityIdFactory instead of depending on the HederaConfig Refactor #17677 to use EntityIdFactory instead of depending on the HederaConfig Feb 13, 2025
@vtronkov vtronkov self-assigned this Feb 17, 2025
@vtronkov vtronkov added this to the v0.60 milestone Feb 17, 2025
@vtronkov
Copy link
Contributor Author

The only place we need to inject the EntityIdFactory is in HandleHederaNativeOperations in smart-contract services. We will leave that to the smart-contract team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vtronkov vtronkov

Labels
None yet
Projects
None yet
Milestone
v0.60
Development

No branches or pull requests
1 participant
@vtronkov