chore: In CI @HapiTests, use spec name as default memo
#17870
Conversation
Signed-off-by: Michael Tinker <[email protected]>
hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/HapiSpecSetup.java
Show resolved
Hide resolved
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17870 +/- ##
============================================
- Coverage 69.01% 69.01% -0.01%
+ Complexity 23050 23048 -2
============================================
Files 2655 2655
Lines 99675 99675
Branches 10289 10289
============================================
- Hits 68795 68793 -2
- Misses 26981 26983 +2
Partials 3899 3899 see 1 file with indirect coverage changes |
Signed-off-by: Michael Tinker <[email protected]>
tinker-michaelj
dismissed stale reviews from mhess-swl and david-bakin-sl
via
f8c2e31
hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/HapiSpec.java
Show resolved
Hide resolved
Signed-off-by: Michael Tinker <[email protected]>
…s-default-memo-in-ci
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
| * <i>metadata</i> of nodes, but not the set of nodes itself; so pre-handle threads | ||
| * can use any version of the map to test for address book membership.) | ||
| */ | ||
| private Map<Long, NodeInfo> nodeInfos; |
There was a problem hiding this comment.
I suggest to make this field volatile. It probably does not matter because the pre-handle threads can use any version as you write, but it would make it more obvious that this field is accessed by multiple threads.
| @@ -113,8 +120,7 @@ public boolean containsNode(final long nodeId) { | |||
|
|
|||
| @Override | |||
| public void updateFrom(@NonNull final State state) { | |||
| nodeInfos.clear(); | |||
| nodeInfos.putAll(nodeInfosFrom(state)); | |||
| nodeInfos = nodeInfosFrom(state); | |||
There was a problem hiding this comment.
To play it safe, I think nodeInfosFrom() should return an unmodifiable Map. Wrapping the generated Map with Collections.unmodifiableMap() should be sufficient here.
Description:
@HapiTestname as default memo for involved transactions #17869