Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ember & Ember Data 1.13.x Tracks #78

Open
rb2020 opened this issue Jun 13, 2015 · 3 comments
Open

Support Ember & Ember Data 1.13.x Tracks #78

rb2020 opened this issue Jun 13, 2015 · 3 comments

Comments

@rb2020
Copy link

rb2020 commented Jun 13, 2015

Glimmer seems to minimally restrict accessing the product page. This error occurs..

Error while processing route: spree.products.index Cannot read property 'length' of undefined TypeError: Cannot read property 'length' of undefined

Repo: https://github.com/e-karma/ember-spree-bare-app.git

@givanse
Copy link

givanse commented Jul 9, 2015

That is not a Glimmer issue, please edit the title, you can see from the stack that the problem is ember-data related. Spree-ember works with the following combination:

"ember": "1.13.0"
"ember-data": "1.0.0-beta.18"

beta 19 introduced the change that causes the error

@hhff hhff changed the title Support for Glimmer - 1.13.0 AND/OR Ember-2.0-Beta Support Ember & Ember Data 1.13.x Tracks Jul 10, 2015
@hhff
Copy link
Owner

hhff commented Jul 10, 2015

Thanks @givanse - there's a ton of work that's got to go into this issue - I've done some preliminary stuff but It's not ready for a PR yet.

@givanse
Copy link

givanse commented Jul 12, 2015

@hhff It would be good to have a branch or PR with those changes, even if it breaks things. I could look at that and see if I can help ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants