Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Update to hcloud-go v2 #877

Closed
apricote opened this issue Feb 23, 2024 · 2 comments
Closed

[Feature]: Update to hcloud-go v2 #877

apricote opened this issue Feb 23, 2024 · 2 comments
Labels
dependencies enhancement pinned

Comments

@apricote
Copy link
Member

What whould you like to see?

We should switch from the deprecated hcloud-go v1 to v2. This will be possible once we have fully migrated to the new Plugin Framework (#752).
@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.

@github-actions github-actions bot added the stale label May 24, 2024
@jooola jooola added pinned and removed stale labels May 24, 2024
@apricote apricote mentioned this issue Aug 8, 2024
Open
@apricote apricote mentioned this issue Sep 13, 2024
Open
71 tasks
@jooola jooola added the requires: plugin-framework The issue can be fixed after the resource has be migrated to the plugin framework. label Dec 13, 2024
@jooola jooola mentioned this issue Dec 23, 2024
Merged
jooola added a commit that referenced this issue Feb 5, 2025
@jooola
fix: upgrade hcloud-go to v2 (#1062)
6f04b15 
Attempt to migrate the hcloud-go library to v2, to be able to finally
drop the v1 version.

We previously discussed of not going this route, but the effort of
porting new features in both hcloud-go versions is bigger than upgrade
the library in the terrafrom plugin.

If this change ends up being impossible to test and too dangerous, we
will just continue the route we initially choose: migrating for to the
plugin framework then the hcloud-go library.

Related to #877
@jooola
Copy link
Member

jooola commented Feb 5, 2025

Solved by #1062

@jooola jooola closed this as completed Feb 5, 2025
@jooola jooola removed the requires: plugin-framework The issue can be fixed after the resource has be migrated to the plugin framework. label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies enhancement pinned
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apricote @jooola