Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Distribute PDB files alongside DLLs #41

Open
JimiC opened this issue Jun 23, 2022 · 6 comments
Open

Suggestion: Distribute PDB files alongside DLLs #41

JimiC opened this issue Jun 23, 2022 · 6 comments

Comments

@JimiC
Copy link

JimiC commented Jun 23, 2022

Distributing the .pdb files will help us debug your library from within our code.

https://devblogs.microsoft.com/visualstudio/debugging-external-sources-with-visual-studio/

@henon
Copy link
Owner

henon commented Jun 23, 2022

I added <IncludeSymbols>true</IncludeSymbols> to the csproj files which generates a Python.Deployment.1.4.1.symbols.nupkg in addition to the Python.Deployment.1.4.1.nupkg package. However, it won't let me upload that as it competes with the 1.4.1 package without symbols.

@henon
Copy link
Owner

henon commented Jun 23, 2022

According to https://stackoverflow.com/questions/41713693/include-pdb-files-into-my-nuget-nupkg-files there is a way to include the PDBs with

<files>
    <file src="bin\$configuration$\$id$.pdb" target="lib\net452\" />
</files>

but I don't know where I should put that. Surely not in the csproj file, right?

@JimiC
Copy link
Author

JimiC commented Jun 23, 2022

At some point your are creating a zip file on release. Include the pdb file in it.

Come to think of it again, I suppose that the nuget tool does the zipping, so the above suggestion is not applicable. Let me do a search on the matter.

@henon
Copy link
Owner

henon commented Jun 23, 2022

I use the Create package on build feature. When compiling the project it automatically generates the nugets. It is convenient. I guess using the command line with dotnet pack --include-symbols --include-source instead might solve it. I could probably upload them as separate debug packages like Python.Deployment.Debug.1.4.1.nupkg so you can switch at will.

@JimiC
Copy link
Author

JimiC commented Jun 23, 2022

I added <IncludeSymbols>true</IncludeSymbols> to the csproj files which generates a Python.Deployment.1.4.1.symbols.nupkg in addition to the Python.Deployment.1.4.1.nupkg package. However, it won't let me upload that as it competes with the 1.4.1 package without symbols.

Yes. It won't allow you to upload a package that is already released because there are security risks or breaking changes by doing that. Same goes for npm where I have more knowledge of.

@JimiC
Copy link
Author

JimiC commented Jun 23, 2022

Python.Deployment.Debug.1.4.1.nupkg

That's a reasonable solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants