Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barebones LSP for integration testing #9430

Closed
kirawi opened this issue Jan 26, 2024 · 1 comment
Closed

Barebones LSP for integration testing #9430

kirawi opened this issue Jan 26, 2024 · 1 comment
Labels
C-enhancement Category: Improvements E-medium Call for participation: Experience needed to fix: Medium / intermediate

Comments

@kirawi
Copy link
Member

kirawi commented Jan 26, 2024

I think it would be a good idea to test our LSP code by having a barebones LSP with some helper functions. Something like this could have caught #9429 if we had a test where we have some diagnostics, e.g. helper_lsp.set_diagnostics(&[(0, 0, "diagnostic here")]) and tested if it appeared in the document itself.

@kirawi kirawi added the C-enhancement Category: Improvements label Jan 26, 2024
@kirawi kirawi added the E-medium Call for participation: Experience needed to fix: Medium / intermediate label Mar 31, 2024
@Omar-Elrefaei
Copy link

Is this still relevant in light of this comment? #6486 (comment)

I'm very wary of adding integration tests against a language server. ....... On balance I don't think LSP integration tests are worth their added weight and I would prefer we test LSP features manually.

If not, I might be interested in taking this on.

@helix-editor helix-editor locked and limited conversation to collaborators Dec 5, 2024
@the-mikedavis the-mikedavis converted this issue into discussion #12193 Dec 5, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
C-enhancement Category: Improvements E-medium Call for participation: Experience needed to fix: Medium / intermediate
Projects
None yet
Development

No branches or pull requests

2 participants