-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [BUG] - Better Token Recognition #261
Comments
hey @0xIchigo , I would like to try my hands on this issue thanks |
Hey @kamalbuilds, go for it! I just assigned the issue over to you |
Hey @kamalbuilds, any update? |
gm @0xIchigo, I attempted to replicate the issue by setting up the repository locally, but the tokens didn't show up. I believe API keys might be needed. Can we discuss this further on Twitter, Discord, or anywhere you prefer? |
gm @ATREAY ! To build locally, fill in the following |
hey @0xIchigo, I would like to give it a try. |
Hey @0xIchigo, |
gm @shreyanshrathore, go for it! The fallback name should be something like "Unrecognized Token" |
Hey @0xIchigo, I have tried my best and fixed the issue. If you have any suggestions or anything that I can do to merge it into the code, please share it with me. |
…Recognition Fix #261 : Better Token Recognition
Fixed by #291 — thank you @shreyanshrathore for the contribution! |
Description
We do not properly display certain tokens under the Tokens page for an account. For example, in the screenshot provided, we do not display any token name or symbol for TheSolanDAO (
7SZUnH7H9KptyJkUhJ5L4Kee5fFAbqVgCHvt7B6wg4Xc
). This shouldn't be the case, as it is a recognized token on Jupiter and Solscan.If a token does not have a picture, we should have a fallback picture. We do this when we can't fetch an asset's picture (see the second screenshot)
Reproduction URL
https://xray.helius.xyz/account/68VhXhZSQxBqC1fBLXnFb2tMiuh3tmiizpZKLTYTwgNG/tokens?network=mainnet
Reproduction steps
1. Go to https://xray.helius.xyz/account/68VhXhZSQxBqC1fBLXnFb2tMiuh3tmiizpZKLTYTwgNG/tokens?network=mainnet 2. See error
Screenshots
The text was updated successfully, but these errors were encountered: