Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x SE metrics does not correctly add app tag if app-name config is set #9664

Open
tjquinno opened this issue Jan 17, 2025 · 0 comments · May be fixed by #9665
Open

4.x SE metrics does not correctly add app tag if app-name config is set #9664

tjquinno opened this issue Jan 17, 2025 · 0 comments · May be fixed by #9665
Assignees
Labels
4.x Version 4.x bug Something isn't working metrics P2
Milestone

Comments

@tjquinno
Copy link
Member

Environment Details

  • Helidon Version: 4.x
  • Helidon SE or Helidon MP SE
  • JDK version:
  • OS:
  • Docker version (if applicable):

Problem Description

Both SE and MP should--and are documented--to allow the user to configure an app name value which causes a tag to be added automatically to every meter. The SE setting is (should be) metrics.app-name and in MP mp.appName (as specified by MicroProfile Metrics).

This works correctly with MP in which the mp_app tag is correctly applied.

But it does not work in SE. Also assigning the app-tag-name (in SE) allows this to work but should not be needed.

Steps to reproduce

In an SE app assign the documented metrics.app-name value. There is no app=some-value tag applied to every meter.

@tjquinno tjquinno added 4.x Version 4.x bug Something isn't working metrics P2 labels Jan 17, 2025
@tjquinno tjquinno added this to the 4.2.0 milestone Jan 17, 2025
@tjquinno tjquinno self-assigned this Jan 17, 2025
@tjquinno tjquinno added this to Backlog Jan 17, 2025
@github-project-automation github-project-automation bot moved this to Triage in Backlog Jan 17, 2025
@tjquinno tjquinno moved this from Triage to Sprint Scope in Backlog Jan 17, 2025
@tjquinno tjquinno linked a pull request Jan 17, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x bug Something isn't working metrics P2
Projects
Status: Sprint Scope
Development

Successfully merging a pull request may close this issue.

1 participant