From 8652606f5bfb07dc4ebbd3dc21e3d54ff7e00d0d Mon Sep 17 00:00:00 2001
From: Tomas Langer <tomas.langer@oracle.com>
Date: Thu, 6 Feb 2025 16:06:20 +0100
Subject: [PATCH] Review fixes.

---
 .../src/main/java/io/helidon/integrations/langchain4j/Ai.java | 2 +-
 integrations/langchain4j/pom.xml                              | 2 +-
 .../providers/open-ai/src/main/java/module-info.java          | 1 -
 .../providers/open-ai/src/test/resources/application.yaml     | 4 ++--
 4 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/integrations/langchain4j/langchain4j/src/main/java/io/helidon/integrations/langchain4j/Ai.java b/integrations/langchain4j/langchain4j/src/main/java/io/helidon/integrations/langchain4j/Ai.java
index 66fdcf58b21..bd40205ce43 100644
--- a/integrations/langchain4j/langchain4j/src/main/java/io/helidon/integrations/langchain4j/Ai.java
+++ b/integrations/langchain4j/langchain4j/src/main/java/io/helidon/integrations/langchain4j/Ai.java
@@ -71,7 +71,7 @@ private Ai() {
      *   <li>{@code dev.langchain4j.rag.content.retriever.ContentRetriever} - Retrieves relevant content to support responses
      *   .</li>
      *   <li>{@code dev.langchain4j.rag.RetrievalAugmentor} - Enhances retrieval processes with additional context.</li>
-     *   <li>CDI bean methods annotated with {@code dev.langchain4j.agent.tool.Tool} -
+     *   <li>Service methods annotated with {@code dev.langchain4j.agent.tool.Tool} -
      *       Tool methods that further extend service capabilities.</li>
      * </ul>
      *
diff --git a/integrations/langchain4j/pom.xml b/integrations/langchain4j/pom.xml
index f4476d1f2df..d3c98b4b19b 100644
--- a/integrations/langchain4j/pom.xml
+++ b/integrations/langchain4j/pom.xml
@@ -40,7 +40,7 @@
     </modules>
 
     <description>
-        Helidon Micrometer Integration
+        Helidon Langchain4j Integration
     </description>
 
 </project>
diff --git a/integrations/langchain4j/providers/open-ai/src/main/java/module-info.java b/integrations/langchain4j/providers/open-ai/src/main/java/module-info.java
index 676ca01caad..729799753dd 100644
--- a/integrations/langchain4j/providers/open-ai/src/main/java/module-info.java
+++ b/integrations/langchain4j/providers/open-ai/src/main/java/module-info.java
@@ -36,7 +36,6 @@
     requires transitive io.helidon.service.registry;
     requires transitive io.helidon.integrations.langchain4j;
     requires transitive io.helidon.common.config;
-    requires jdk.jfr;
 
     exports io.helidon.integrations.langchain4j.providers.openai;
 }
\ No newline at end of file
diff --git a/integrations/langchain4j/providers/open-ai/src/test/resources/application.yaml b/integrations/langchain4j/providers/open-ai/src/test/resources/application.yaml
index 231919f2c4f..468cd70fa05 100644
--- a/integrations/langchain4j/providers/open-ai/src/test/resources/application.yaml
+++ b/integrations/langchain4j/providers/open-ai/src/test/resources/application.yaml
@@ -42,7 +42,7 @@ langchain4j.open-ai:
     log-responses: true
     custom-headers.header1: value1
     custom-headers.header2: value2
-    # StreamingChatModel
+  # StreamingChatModel
   streaming-chat-model:
     api-key: api-key
     model-name: model-name
@@ -50,7 +50,7 @@ langchain4j.open-ai:
     organization-id: organization-id
     temperature: 36.6
     top-p: 10
-    stop: stop1,stop2,stop3
+    stop: ["stop1", "stop2", "stop3"]
     max-tokens: 15
     max-completion-tokens: 20
     presence-penalty: 0.1