Slight refactor to Vector Index get #1248
Merged
+32
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1248 +/- ##
==========================================
+ Coverage 91.55% 91.56% +0.01%
==========================================
Files 42 42
Lines 9539 9552 +13
Branches 1926 1928 +2
==========================================
+ Hits 8733 8746 +13
Misses 523 523
Partials 283 283 ☔ View full report in Codecov by Sentry. |
Closed
3 tasks
|
@mavaylon1 tested again on my end an this dramatically speeds things up :) |
mavaylon1
commented
Feb 19, 2025
|
This looks good to me, but see comment above |
rly
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
hdmf-dev/hdmf-zarr#237
Using to_dataframe in Zarr is slower than HDF5, most likely due to how we handle references. The change is gathering all the data at once to resolve, rather than multiple I/O reads iteratively.
Checklist
CHANGELOG.mdwith your changes?