Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scipy to test dependencies #261

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Add scipy to test dependencies #261

merged 2 commits into from
Jan 29, 2025

Conversation

rly
Copy link
Contributor

@rly rly commented Jan 25, 2025

Motivation

Tests are failing because HDMF 4.0 removed scipy as a primary dependency and hdmf-zarr uses scipy in some tests. We need to add it to the test optional dependency group.

How to test the behavior?

Run tests

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.87%. Comparing base (b04e37c) to head (5348874).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #261   +/-   ##
=======================================
  Coverage   86.87%   86.87%           
=======================================
  Files           5        5           
  Lines        1196     1196           
  Branches      227      227           
=======================================
  Hits         1039     1039           
  Misses         98       98           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly marked this pull request as ready for review January 28, 2025 23:12
@rly rly requested a review from mavaylon1 January 28, 2025 23:12
@rly rly enabled auto-merge (squash) January 29, 2025 16:46
@rly rly requested a review from oruebel January 29, 2025 16:46
@rly rly merged commit 4f95dfd into dev Jan 29, 2025
25 checks passed
@rly rly deleted the add_scipy_test branch January 29, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants