Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't open with consolidated metadata in mode r+ #193

Merged
merged 8 commits into from
May 26, 2024
Merged

Don't open with consolidated metadata in mode r+ #193

merged 8 commits into from
May 26, 2024

Conversation

mavaylon1
Copy link
Contributor

@mavaylon1 mavaylon1 commented May 16, 2024

Motivation

What was the reasoning behind this change? Please explain the changes briefly.
Fix #182

The fix is to open without consolidated metadata when in mode r+.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.05%. Comparing base (07a5bb2) to head (5357b2e).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #193   +/-   ##
=======================================
  Coverage   86.05%   86.05%           
=======================================
  Files           5        5           
  Lines        1162     1162           
  Branches      287      287           
=======================================
  Hits         1000     1000           
  Misses        107      107           
  Partials       55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1 mavaylon1 added this to the 0.8.0 milestone May 16, 2024
@mavaylon1
Copy link
Contributor Author

Review Notes:
I do not think a test is needed for this.

@mavaylon1 mavaylon1 self-assigned this May 16, 2024
@mavaylon1 mavaylon1 marked this pull request as ready for review May 22, 2024 20:55
@mavaylon1 mavaylon1 requested review from oruebel and rly May 22, 2024 22:53
@mavaylon1 mavaylon1 merged commit 0b72774 into dev May 26, 2024
24 checks passed
@mavaylon1 mavaylon1 deleted the append branch May 26, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: NWBZarrIO appending
3 participants