Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitrate Computation and SEI Messages #9

Open
haudiobe opened this issue Dec 15, 2020 · 4 comments
Open

Bitrate Computation and SEI Messages #9

haudiobe opened this issue Dec 15, 2020 · 4 comments
Labels
agreed-needs-implementation Agreed and needs implementation

Comments

@haudiobe
Copy link
Owner

haudiobe commented Dec 15, 2020

From @galpinf:
6) MD5 of bitstream (Optional may be tricky depending on the codec or SEI usage)
7) Metrics (where is calculated the rate? Should be before SEIs – at the encoder log level, not file level)

@haudiobe
Copy link
Owner Author

Why would the encoder add SEIs? And if it adds SEIs and the SEIs are relevant/necessary, then they should count.

I believe we should not use the encoder log for the bitrate. It should be the file size. Also MD5 is for the bitstream.

Please confirm

@haudiobe haudiobe added the question Further information is requested label Dec 15, 2020
@haudiobe
Copy link
Owner Author

No comments received, we use the file size.

@haudiobe haudiobe added agreed-needs-implementation Agreed and needs implementation and removed question Further information is requested labels Jan 27, 2021
@galpinf
Copy link

galpinf commented Jan 27, 2021

1- MD5 SEI in bitstream are convenient to check integrity at frame level (as opposed to file integrity). Workaround: MD5 computation from outside can be adapted to be performed at frame level though.
2-when doing chunk encoding, we might need to adapt the concatenation tools (knows as parcat in vtm) in order to get exactly the same bitstream for comparison if we are not using frame based bitrate

@nlsdvl
Copy link
Collaborator

nlsdvl commented Aug 1, 2021

HM/bin/SEIRemovalAppStatic is now used to compute bitrate for HM/SCM.
Currently, this is disabled for other encoders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agreed-needs-implementation Agreed and needs implementation
Projects
None yet
Development

No branches or pull requests

3 participants