Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note transpose in ClipVariations-Note is tricky to deal with #6

Open
haszari opened this issue Oct 9, 2021 · 0 comments
Open

Note transpose in ClipVariations-Note is tricky to deal with #6

haszari opened this issue Oct 9, 2021 · 0 comments

Comments

@haszari
Copy link
Owner

haszari commented Oct 9, 2021

To make use of the full range, ClipVariations-Note transposes notes down:

https://github.com/haszari/PhraseSyncPlugins/blob/main/NoteFilter/Source/PluginProcessor.cpp#L242-L246

This has the effect of transposing the lowest/default pattern to a different note range when the plugin is enabled (vs disabled). So activating the plugin is not transparent; the pattern needs to be authored differently, or the variations plugin needs to be paired with another transpose (which is dependent on the variation height param).

It would be helpful to add a transpose so that notes in the first variation are less likely to be transposed, or to standardise another variation to be the "home" variation. It may be better to set the lowest variation (e.g. C-2 up) as the default, untransposed pattern. If this approach is used, most instruments would need to be transposed to suit (e.g. drums often start at C1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant