Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can get dangling notes when switching variations (ClipVariations-Note) #5

Open
haszari opened this issue Sep 20, 2021 · 1 comment
Open

Comments

@haszari
Copy link
Owner

haszari commented Sep 20, 2021

If one of the variations has a note that ends near the phrase boundary (end of loop), when switching away from that variation, the note-off won't get through. So that note continues to play (forever).

Workaround: shorten the note so it's further away from the end of the loop.

@haszari
Copy link
Owner Author

haszari commented Oct 9, 2021

Possible solutions:

  • Send an all notes off message whenever the variation changes. This could cut/clip any notes longer than the loop region (or past phrase boundary for longer patterns).
  • Keep track of all the note-ons with an array or MidiKeyboardState. Then either send those specific note-offs on variation switch, or use this to "play" the muted variation's note-offs at the correct time. This would allow note-offs past the phrase boundary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant