Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awscc_pcs_compute_node_group not available in Terraform registry #2157

Open
mszuma opened this issue Jan 10, 2025 · 5 comments
Open

awscc_pcs_compute_node_group not available in Terraform registry #2157

mszuma opened this issue Jan 10, 2025 · 5 comments
Assignees
Labels
bug upstream-aws Unable to proceed due to missing or broken functionality from an AWS dependency.

Comments

@mszuma
Copy link

mszuma commented Jan 10, 2025

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
  • The resources and data sources in this provider are generated from the CloudFormation schema, so they can only support the actions that the underlying schema supports. For this reason submitted bugs should be limited to defects in the generation and runtime code of the provider. Customizing behavior of the resource, or noting a gap in behavior are not valid bugs and should be submitted as enhancements to AWS via the CloudFormation Open Coverage Roadmap.

Description

The aws_pcs_compute_node_group resource schema is listed in terraform-provider-awscc all_schemas.hcl without a suppression reason, and AWS::PCS::ComputeNodeGroup is available in the AWS CloudFormation registry, but awscc_pcs_compute_node_group is not available in the Terraform registry.

Other PCS service resources awscc_pcs_cluster and awscc_pcs_queue are available in the Terraform registry.

When attempting to add an awscc_pcs_compute_node_group resource to a Terraform project, there is an error The provider hashicorp/awscc does not support resource type "awscc_pcs_compute_node_group"

Affected Resource(s)

  • awscc_pcs_compute_node_group
@mszuma mszuma added the bug label Jan 10, 2025
@quixoticmonk quixoticmonk self-assigned this Jan 10, 2025
@quixoticmonk
Copy link
Collaborator

@ewbankkit Is this one of the resources suppressed due to a build failure ?

@quixoticmonk
Copy link
Collaborator

Digging further into a build with the latest schema, the build fails with the error message below.

error loading CloudFormation Resource Provider Schema for aws_pcs_compute_node_group: loading ../service/cloudformation/schemas/AWS_PCS_ComputeNodeGroup.json: loading JSON Schema ({
  "typeName": "AWS::PCS::ComputeNodeGroup",
....
): pattern must be a valid regex

The changes I can see in the latest schema are

Image

Image

@quixoticmonk quixoticmonk added upstream-aws Unable to proceed due to missing or broken functionality from an AWS dependency. and removed needs-triage labels Jan 15, 2025
@mszuma
Copy link
Author

mszuma commented Jan 24, 2025

Change has been deployed to CloudFormation to remove the negative lookahead regex causing issue. Waiting on the latest changes to be released in the repo.

@johnsonaj
Copy link
Contributor

After some investigation it looks like this resource is silently failing to register during initialization with the following error: duplicate attribute name mapping for CloudFormation property Id. This is produced when TF attributes are mapped to CF attributes:

func resourceWithAttributeNameMap(v map[string]string) ResourceOptionsFunc {

The Id property in CustomLaunchTemplate is conflicting with the top level Id property when creating the map. Id is referenced both on compute_node_group_id and id

@murphm8
Copy link

murphm8 commented Feb 5, 2025

Is there any way to not do this flattening, or to work around it? To fix this on our side it would require renaming a field in the public CloudFormation schema, which is a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug upstream-aws Unable to proceed due to missing or broken functionality from an AWS dependency.
Projects
None yet
Development

No branches or pull requests

4 participants